Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new FWLite dependencies #13254

Closed
smuzaffar opened this issue Feb 11, 2016 · 11 comments
Closed

new FWLite dependencies #13254

smuzaffar opened this issue Feb 11, 2016 · 11 comments

Comments

@smuzaffar
Copy link
Contributor

#13204 brings in extra FWLite dependencies e.g

DataFormats/HGCRecHit
Geometry/HGCalGeometry

for which many other Geometry packages are needed. Either dependency chain should be cleaned up or please update https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_8_0_X/stable/fwlite_build_set.file

@cmsbuild
Copy link
Contributor

A new Issue was created by @smuzaffar (Malik Shahzad Muzaffar).

@davidlange6, @smuzaffar, @Degano, @davidlt, @Dr15Jones can you please review it and eventually sign/assign? Thanks.

cms-bot commands are list here #13029

@smuzaffar
Copy link
Contributor Author

assign visualization

@cmsbuild
Copy link
Contributor

New categories assigned: visualization

@Dr15Jones,@alja you have been requested to review this Pull request/Issue and eventually sign? Thanks

@smuzaffar smuzaffar changed the title new FWLite depedencies new FWLite dependencies Feb 11, 2016
@osschar
Copy link
Contributor

osschar commented Feb 11, 2016

I guess we should add DataFormats/HGCRecHit to the fwlite_build_set.file (unless it pulls in extra non-fwlite stuff, that is).

Fireworks/Geometry is not part of fwlite so addition of Geometry/HGCalGeometry is not a problem.

@smuzaffar
Copy link
Contributor Author

I have not checked but looks like they do bring in a lot other packages too.

@osschar
Copy link
Contributor

osschar commented Feb 11, 2016

Looking at DataFormats/HGCRecHit/BuildFile.xml and dependencies it seems DataFormats/ForwardDetId is the missing one. This in turn requires FWCore/Utilities and DataFormats/DetId which are both already part of fwlite.

@alja
Copy link
Contributor

alja commented Feb 15, 2016

Looking at the commit #13204 only DataFormats/HGCRecHit package is needed in FWLite pacakge Fireworks/Calo.

The package Fireworks/Geometry is not part of FWLite. This is the one that has dependency to Geometry/HGCalGeometry.

I'm on a family leave till February 29th. I will double check this when I come back.

@smuzaffar
Copy link
Contributor Author

cms-sw/cmsdist@f97336c has fixed the fwlite dependency. following packages were missing

DataFormats/ForwardDetId
DataFormats/HGCRecHit

@alja
Copy link
Contributor

alja commented Feb 26, 2016

Thanks!
I guess this issue can be closed.

@alja
Copy link
Contributor

alja commented Mar 1, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2016

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants