-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new FWLite dependencies #13254
Comments
A new Issue was created by @smuzaffar (Malik Shahzad Muzaffar). @davidlange6, @smuzaffar, @Degano, @davidlt, @Dr15Jones can you please review it and eventually sign/assign? Thanks. cms-bot commands are list here #13029 |
assign visualization |
New categories assigned: visualization @Dr15Jones,@alja you have been requested to review this Pull request/Issue and eventually sign? Thanks |
I guess we should add DataFormats/HGCRecHit to the fwlite_build_set.file (unless it pulls in extra non-fwlite stuff, that is). Fireworks/Geometry is not part of fwlite so addition of Geometry/HGCalGeometry is not a problem. |
I have not checked but looks like they do bring in a lot other packages too. |
Looking at DataFormats/HGCRecHit/BuildFile.xml and dependencies it seems DataFormats/ForwardDetId is the missing one. This in turn requires FWCore/Utilities and DataFormats/DetId which are both already part of fwlite. |
Looking at the commit #13204 only DataFormats/HGCRecHit package is needed in FWLite pacakge Fireworks/Calo. The package Fireworks/Geometry is not part of FWLite. This is the one that has dependency to Geometry/HGCalGeometry. I'm on a family leave till February 29th. I will double check this when I come back. |
cms-sw/cmsdist@f97336c has fixed the fwlite dependency. following packages were missing
|
Thanks! |
+1 |
This issue is fully signed and ready to be closed. |
#13204 brings in extra FWLite dependencies e.g
DataFormats/HGCRecHit
Geometry/HGCalGeometry
for which many other Geometry packages are needed. Either dependency chain should be cleaned up or please update https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_8_0_X/stable/fwlite_build_set.file
The text was updated successfully, but these errors were encountered: