Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HGC RecHits / Reco Geometry to Fireworks #13204

Merged
merged 2 commits into from Feb 10, 2016

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Feb 5, 2016

This PR adds the HGCal geometries (V5 and V7) such that they are processed and written to disk for the fireworks RECO geometry.

I also added a rechit proxy builder, showing that things look mostly reasonable (this is a jet gun event).
It would be useful if we could remove the scaling from RecHit view and just see the hits directly, right now they are scaled to be very tiny since they only contain energies of few tens-hundreds of keV.

Example of hex geometry:
screen shot 2016-02-05 at 13 25 42

@vandreev11 @sethzenz @kpedro88

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2016

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_0_X.

It involves the following packages:

Fireworks/Calo
Fireworks/Geometry

@cmsbuild, @alja, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@lgray
Copy link
Contributor Author

lgray commented Feb 5, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11020/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2016

@lgray
Copy link
Contributor Author

lgray commented Feb 5, 2016

@cseez FYI.

@lgray
Copy link
Contributor Author

lgray commented Feb 6, 2016

@alja please review when you are able. Thanks!

@alja
Copy link
Contributor

alja commented Feb 8, 2016

@lgray
I will add option for seeing det hits without scaling. Currently I'm on a family leave and will be back on 29 of February. I will try to get this earlier.

@alja
Copy link
Contributor

alja commented Feb 8, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Feb 10, 2016
Add HGC RecHits / Reco Geometry to Fireworks
@cmsbuild cmsbuild merged commit dec210f into cms-sw:CMSSW_8_0_X Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants