FEDTrailer/FEDHeader needs a namespace

[davidlt]

While debugging code I noticed that we have two implementations of FEDTrailer and FEDHeader (at least), e.g.

(gdb)  b FEDTrailer::check()
Breakpoint 2 at 0x3fff8e712e80: FEDTrailer::check(). (2 locations)
(gdb) info b
Num     Type           Disp Enb Address            What
1       breakpoint     keep y   0x00003fff4c46bf20 in l1t::L1TRawToDigi::produce(edm::Event&, edm::EventSetup const&) at /home/david.abdurachmanov/gcc530_framework/CMSSW_8_1_X_2016-04-26-2300-cms/src/EventFilter/L1TRawToDigi/plugins/L1TRawToDigi.cc:158
        breakpoint already hit 1 time
2       breakpoint     keep y   <MULTIPLE>
2.1                         y     0x00003fff8e712e80 in FEDTrailer::check() at /home/david.abdurachmanov/gcc530_framework/CMSSW_8_1_X_2016-04-26-2300-cms/src/EventFilter/FEDInterface/src/FEDTrailer.cc:78
2.2                         y     0x00003fff98458804 in FEDTrailer::check() at /home/david.abdurachmanov/gcc530_framework/CMSSW_8_1_X_2016-04-26-2300-cms/src/DataFormats/FEDRawData/src/FEDTrailer.cc:75

Files are still marked as temporarily copied from XDAQ (that was 11 years ago?). Seems that newer version is in EventFilter/FEDInterface package.

[cmsbuild]

A new Issue was created by @davidlt .

@davidlange6, @smuzaffar, @Degano, @davidlt, @Dr15Jones can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[davidlt]

assign daq

[cmsbuild]

New categories assigned: daq

@mommsen,@emeschi you have been requested to review this Pull request/Issue and eventually sign? Thanks

[davidlt]

Back in 2008:

commit 3b02d60548843614cba9769711547b7ac51905d8
Author: Peter Elmer <sha1-80460c2ac58e1aa0fd289ec2aa9d168a17bd6eb2@cern.ch>
Date:   Tue Jul 1 21:50:36 2008 +0000

    Add FEDHeader.* and FEDHeader.cc, moved here temporarily from
    EventFilter/Utilities, in order to break the xdaq dependency from the
    main offline applications. The next step will be eliminating these altogether
    in favor of those in DataFormats/FEDRawData (and make those depend on
    the xdaq headers, but no the xdaq libraries)

Someone needs to untangle the things.

[davidlt]

ping^1

[mommsen]

This issue has been addressed with #21690 and could be closed.