Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate header for fed_trailer.h #21312

Closed
davidlt opened this issue Nov 15, 2017 · 6 comments
Closed

Duplicate header for fed_trailer.h #21312

davidlt opened this issue Nov 15, 2017 · 6 comments

Comments

@davidlt
Copy link
Contributor

davidlt commented Nov 15, 2017

While looking at output for validateJR comparison tests I noticed that we have two headers for the same (?) thing:

ROOT Cling run-time complaint about struct redefinition: error: redefinition of 'fedh_struct'

The one in DataFormats/FEDRawData was done 12 years ago and commit mentioned that it should be temporary. The one in EventFilter/FEDInterface seems to be a better rewrite of old stuff.

@davidlt
Copy link
Contributor Author

davidlt commented Nov 15, 2017

Ah, I already have filled a bug report for this back in 2016: #14353

@cmsbuild
Copy link
Contributor

A new Issue was created by @davidlt .

@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

assign daq

@cmsbuild
Copy link
Contributor

New categories assigned: daq

@mommsen,@emeschi you have been requested to review this Pull request/Issue and eventually sign? Thanks

@mommsen
Copy link
Contributor

mommsen commented Jan 9, 2018

This issue has been addressed with #21690 and could be closed.

@smuzaffar
Copy link
Contributor

closing it as it has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants