Bugs to fix when turning CMSSW_9_0_0_pre4 into CMSSW_8_3_0

[davidlange6]

please add pointers to PRs or discussions here. (this is not for new features..)

[cmsbuild]

A new Issue was created by @davidlange6 David Lange.

@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here #13029

[davidlange6]

Issues I'm aware of

1. We may be asked to revert the ME0 geometry changes made between pre2 and pre3 (@kpedro88)
2. There are some L1 related exceptions in the IB for phase2 related workflows (I believe), most likely due to Pr90x L1T Stage2 for Phase2 #17248 (@rekovic) [this is "resolved" in pre4 since Pr90x L1T Stage2 for Phase2 #17248 was reverted - I cleaned up the comments in this discussion to reduce confusion]

[kpedro88]

The specific ME0 commit to revert is #17175.

[boudoul]

you may want to include #17390 (just removing some forgotten couts for phase2)

[davidlange6]

#17390 is also in pre4.

[Martin-Grunewald]

#17438 (needed for ConfDB parsing) - bug fixes in py files

[davidlange6]

Some printouts that need fixing

*** MonitorElement: WARNING:setBinLabel: attempting to set label of non-existent bin number for ME: Hcal/DigiPhase1Task/OccupancyCut/FED/
*** MonitorElement: WARNING:setBinLabel: attempting to set label of non-existent bin number for ME: Hcal/DigiPhase1Task/OccupancyCut/FED/
*** MonitorElement: WARNING:setBinLabel: attempting to set label of non-existent bin number for ME: Hcal/DigiPhase1Task/OccupancyCut/FED/

%MSG-w TrackerValidationVariables: SiPixelPhase1TrackResiduals:SiPixelPhase1TrackResidualsAnalyzer TrackerValidationVariables::fillHitQuantities() 10-Feb-2017 15:15:06 CE
T Run: 1 Event: 1
No valid tracker subdetector 2
%MSG

[kpedro88]

FYI, I ran a test for the ME0 reversion to check that GEN-SIM can be reused:

cmsrel CMSSW_9_0_0_pre4
cd CMSSW_9_0_0_pre4/src
cmsenv
git cms-addpkg Configuration/Geometry Geometry/CMSCommonData Geometry/GEMGeometry Geometry/GEMGeometryBuilder Geometry/MuonCommonData Geometry/MuonNumbering
git revert -m 1 6071ff6
scram b -j 8

Then the following script (derived from runTheMatrix for 22823.0, using input GEN-SIM file from /MinBias_TuneCUETP8M1_14TeV-pythia8/PhaseIIFall16GS82-90X_upgrade2023_realistic_v1-v1/GEN-SIM):

#!/bin/bash

# in: /uscms_data/d3/pedrok/phase2/CMSSW_9_0_0_pre4/src dryRun for 'cd 22823.0_MinBias_13+MinBias_13TeV_pythia8_TuneCUETP8M1_2023D4Timing_GenSimHLBeamSpotFull+DigiFullTrigger_2023D4Timing+RecoFullGlobal_2023D4Timing+HARVESTFullGlobal_2023D4Timing
# cmsDriver.py MinBias_13TeV_pythia8_TuneCUETP8M1_cfi  --conditions auto:phase2_realistic -n 10 --era Phase2C2_timing --eventcontent FEVTDEBUG --relval 90000,100 -s GEN,SIM --datatier GEN-SIM --beamspot HLLHC --geometry Extended2023D4 --fileout file:step1.root  > step1_MinBias_13+MinBias_13TeV_pythia8_TuneCUETP8M1_2023D4Timing_GenSimHLBeamSpotFull+DigiFullTrigger_2023D4Timing+RecoFullGlobal_2023D4Timing+HARVESTFullGlobal_2023D4Timing.log  2>&1
 

# in: /uscms_data/d3/pedrok/phase2/CMSSW_9_0_0_pre4/src dryRun for 'cd 22823.0_MinBias_13+MinBias_13TeV_pythia8_TuneCUETP8M1_2023D4Timing_GenSimHLBeamSpotFull+DigiFullTrigger_2023D4Timing+RecoFullGlobal_2023D4Timing+HARVESTFullGlobal_2023D4Timing
 cmsDriver.py step2  --conditions auto:phase2_realistic -s DIGI:pdigi_valid,L1,L1TrackTrigger,DIGI2RAW,HLT:@fake --datatier GEN-SIM-DIGI-RAW -n 10 --geometry Extended2023D4 --era Phase2C2_timing --eventcontent FEVTDEBUGHLT --filein root://eoscms.cern.ch///store/mc/PhaseIIFall16GS82/MinBias_TuneCUETP8M1_14TeV-pythia8/GEN-SIM/90X_upgrade2023_realistic_v1-v1/60000/0007B555-8ACB-E611-ABBF-FA163E6C1BA0.root  --fileout file:step2.root  > step2_MinBias_13+MinBias_13TeV_pythia8_TuneCUETP8M1_2023D4Timing_GenSimHLBeamSpotFull+DigiFullTrigger_2023D4Timing+RecoFullGlobal_2023D4Timing+HARVESTFullGlobal_2023D4Timing.log  2>&1
 

# in: /uscms_data/d3/pedrok/phase2/CMSSW_9_0_0_pre4/src dryRun for 'cd 22823.0_MinBias_13+MinBias_13TeV_pythia8_TuneCUETP8M1_2023D4Timing_GenSimHLBeamSpotFull+DigiFullTrigger_2023D4Timing+RecoFullGlobal_2023D4Timing+HARVESTFullGlobal_2023D4Timing
 cmsDriver.py step3  --conditions auto:phase2_realistic -n 10 --era Phase2C2_timing --eventcontent FEVTDEBUGHLT,MINIAODSIM,DQM --runUnscheduled  -s RAW2DIGI,L1Reco,RECO,PAT,VALIDATION:@phase2Validation+@miniAODValidation,DQM:@phase2+@miniAODDQM --datatier GEN-SIM-RECO,MINIAODSIM,DQMIO --geometry Extended2023D4 --filein file:step2.root  --fileout file:step3.root  > step3_MinBias_13+MinBias_13TeV_pythia8_TuneCUETP8M1_2023D4Timing_GenSimHLBeamSpotFull+DigiFullTrigger_2023D4Timing+RecoFullGlobal_2023D4Timing+HARVESTFullGlobal_2023D4Timing.log  2>&1
 

# in: /uscms_data/d3/pedrok/phase2/CMSSW_9_0_0_pre4/src dryRun for 'cd 22823.0_MinBias_13+MinBias_13TeV_pythia8_TuneCUETP8M1_2023D4Timing_GenSimHLBeamSpotFull+DigiFullTrigger_2023D4Timing+RecoFullGlobal_2023D4Timing+HARVESTFullGlobal_2023D4Timing
 cmsDriver.py step4  --conditions auto:phase2_realistic -s HARVESTING:@phase2Validation+@phase2+@miniAODValidation+@miniAODDQM --era Phase2C2_timing --filein file:step3_inDQM.root --scenario pp --filetype DQM --geometry Extended2023D4 --mc  -n 100  --fileout file:step4.root  > step4_MinBias_13+MinBias_13TeV_pythia8_TuneCUETP8M1_2023D4Timing_GenSimHLBeamSpotFull+DigiFullTrigger_2023D4Timing+RecoFullGlobal_2023D4Timing+HARVESTFullGlobal_2023D4Timing.log  2>&1

The test successfully ran to completion with no strange or unexpected error messages in the logs.

[fwyzard]

please consider #17412 as a fix for 900pre4

[davidlange6]

#17539 likely addresses the tracker dqm messages

[davidlange6]

@kpedro88 - regarding the muon changes above, is there any point in worrying about phase 2 in 8_3_0 ? I guess that without more changes from tracking/trigger this is not a useful release?

[davidlange6]

#17572

[kpedro88]

I guess we should ask the upgrade studies conveners - if they plan to wait for e.g. tracking fake rate fixes to do another production, then it doesn't matter (but we'll then have to remember to revert the ME0 PR for 8_4_0...)

[davidlange6]

last week the statement was that they didn’t plan to use 830. but if you can get an update that would be great.

…

On Feb 20, 2017, at 4:22 PM, Kevin Pedro ***@***.***> wrote: I guess we should ask the upgrade studies conveners - if they plan to wait for e.g. tracking fake rate fixes to do another production, then it doesn't matter (but we'll then have to remember to revert the ME0 PR for 8_4_0...) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[fwyzard]

8.3.0 is needed for urgent studies for 2017, not for upgrade studies

[davidlange6]

we got a tentative no from upgrade so I'll leave out the ME0 revert for the moment.

[davidlange6]

my current recipe is

#17438
git cms-addpkg RecoTracker/DeDx RecoTracker/TkSeedGenerator RecoTauTag/HLTProducers
git cherry-pick 163bdb7 1969bd5

#17412
git cms-addpkg HLTrigger/Configuration
git cherry-pick 38f6eaf 4e316f6 bc24b46 a44496f 49b58ca
485d8152d4f8b08746eca467

#17539
git cms-addpkg Alignment/OfflineValidation
git cherry-pick 1258c84 e4ec05f 462bdbb

#17582
git cms-addpkg DQM/TrackingMonitorSource
git fetch git@github.com:makortel/cmssw silenceTrackSelector
git cherry-pick 8732900

#17579 (issues in harvesting step currently)
#git cms-addpkg DQM/HcalCommon
#git fetch git@github.com:vkhristenko/cmssw fixconstspecifier
#git cherry-pick 35b27cf

#17576
git cms-addpkg DQMOffline/JetMET Validation/RecoTau
git fetch git@github.com:davidlange6/cmssw cmsignores
git cherry-pick 8aad06f 72ff42c

#17572
git cms-addpkg L1Trigger/L1TGlobal
git cherry-pick ee79e59

git cms-addpkg Configuration/PyReleaseValidation
#17422
git cherry-pick 64d48a2
#17464
git cherry-pick 12d6632
#17531
git cherry-pick fb56497
#17458
git cherry-pick c3e61cb

git fetch git@github.com:davidlange6/cmssw hcaldqm
git cherry-pick 83dff97 bdc7715

[davidlange6]

maybe someone will solve the issues with 17579 before the other tests finish, otherwise I'll go ahead.

[davidlange6]

#17585

[davidlange6]

my build was ok- missing the validation go ahead.