Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hltSiPixelPhase1TrackClustersAnalyzer finds incompatible configurations for DQM histos #20192

Closed
perrotta opened this issue Aug 17, 2017 · 15 comments

Comments

@perrotta
Copy link
Contributor

Phase 1 logs show repeatedly the error:

%MSG-e SiPixelPhase1TrackClusters: SiPixelPhase1TrackClusters:hltSiPixelPhase1TrackClustersAnalyzer 16-Aug-2017 18:09:35 CEST Run: 297227 Event: 13844078
incompatible configuration 12!=23
%MSG

(see e.g. https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc630/CMSSW_9_3_X_2017-08-16-2300/pyRelValMatrixLogs/run/136.781_RunDoubleEG2017B+RunDoubleEG2017B+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017/step3_RunDoubleEG2017B+RunDoubleEG2017B+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017.log)

which is generated in
https://cmssdt.cern.ch/lxr/source/DQM/SiPixelPhase1TrackClusters/src/SiPixelPhase1TrackClusters.cc#0093
and due to the fact that the list of histograms in
https://cmssdt.cern.ch/lxr/source/DQMOffline/Trigger/python/SiPixel_OfflineMonitoring_TrackCluster_cff.py#0122
and in
https://cmssdt.cern.ch/lxr/source/DQM/SiPixelPhase1TrackClusters/src/SiPixelPhase1TrackClusters.cc#0063
do not correspond.

Please either fix or shut up the message

@perrotta
Copy link
Contributor Author

assign dqm

@cmsbuild
Copy link
Contributor

New categories assigned: dqm

@kmaeshima,@vanbesien,@vazzolini,@dmitrijus you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

A new Issue was created by @perrotta .

@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor

@fioriNTU ping

@fioriNTU
Copy link
Contributor

This is not standard Pixel DQM, it is related to the HLT monitor and has been developed by @mtosi

@fioriNTU
Copy link
Contributor

@mtosi , just to give an indication on what may be wrong, the off-track clusters plots have been removed by the analyzer code itself, so they are not produced anymore after a PR from @VinInn already merged in 9_3_X by some time ... most probably they have to be removed by that list, but actually, as I said, Mia is the best person to judge

@mtosi
Copy link
Contributor

mtosi commented Aug 29, 2017

uhmmm
I'm totally new on this type of message !
=> apologies for the very low level of questions/doubts

if I understand the message, the system is complaining about a different # of histograms
in our config file [1] we are expecting to create 12 histograms
uhmm, actually even if the list of PSet in hltSiPixelPhase1TrackClustersConf is 12
there are some of these PSets configured to create more than 1! histograms
=> the final multiplicity is larger than 12

looking at the source [2] I see that the list is indeed 23
and that -as pointed by @fioriNTU -- no off-track MEs are listed

@VinInn @perrotta do you have suggestions ?
shall I simply drop the off-track PSets from my list ?
but then, the size of my list will be anyhow different w.r.t. the one in the source code
I'm really confused on how to proceed :(

[1]
https://cmssdt.cern.ch/lxr/source/DQMOffline/Trigger/python/SiPixel_OfflineMonitoring_TrackCluster_cff.py#0122

[2]
https://cmssdt.cern.ch/lxr/source/DQM/SiPixelPhase1TrackClusters/src/SiPixelPhase1TrackClusters.cc#0063

@VinInn
Copy link
Contributor

VinInn commented Aug 29, 2017

as I commented in the code
// copy paste from cfy: the only safe way to doit....
the cc and the python MUST be in sync, if not havoc is guaranteed

@mtosi
Copy link
Contributor

mtosi commented Aug 29, 2017 via email

@VinInn
Copy link
Contributor

VinInn commented Aug 29, 2017

Because it goes by index, in principle you can enable just the first N, still the order is not optimized, so at the moment please just copy paste from offline.
submit a jira ticket to ask enhancement: Marcel is supposed to arrive at Xmas....
see
https://cmssdt.cern.ch/lxr/source/DQM/SiPixelPhase1TrackClusters/python/SiPixelPhase1TrackClusters_cfi.py#0319

@mtosi
Copy link
Contributor

mtosi commented Aug 29, 2017 via email

@mtosi
Copy link
Contributor

mtosi commented Aug 29, 2017 via email

@fioriNTU
Copy link
Contributor

@mtosi and @VinInn, actually using the flag enabled=false in the cfi you can disable whatever plot you want

mtosi added a commit to mtosi/cmssw that referenced this issue Aug 29, 2017
@VinInn
Copy link
Contributor

VinInn commented Aug 29, 2017

Indeed, thanks @fioriNTU.

cmsbuild added a commit that referenced this issue Sep 6, 2017
fix # MEs in pixel DQM@HLT as requested by #20192
@perrotta
Copy link
Contributor Author

perrotta commented Oct 6, 2017

Fixed with #20298

@perrotta perrotta closed this as completed Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants