Too large value used in testHitPattern

[Dr15Jones]

In the test DataFormats/TrackReco/test/testHitPattern.cpp, the test uses an array of uint32_t and is passing those values to a function that takes a uint16_t:
https://github.com/cms-sw/cmssw/blob/master/DataFormats/TrackReco/test/testHitPattern.cpp#L16

The values in the array are larger than the largest allowed 16bit number.

This is generating a clang warning.

[Dr15Jones]

assign reconstruction

[cmsbuild]

New categories assigned: reconstruction

@slava77,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

A new Issue was created by @Dr15Jones Chris Jones.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[Dr15Jones]

@VinInn FYI

[VinInn]

cool!
the test is supposed to test

bool appendHit(const DetId &id, TrackingRecHit::Type hitType, const TrackerTopology& ttopo);

that changed signature in the mean time (topology added)
NOT

bool appendHit(const uint16_t pattern, TrackingRecHit::Type hitType);

[slava77]

+1

this was apparently fixed in #25767

[cmsbuild]

This issue is fully signed and ready to be closed.