Fix HitPattern::stripHitFilter() (10_4_X)

[makortel]

Backport of #25692. Original description:

The HitPattern::stripHitFilter() was counting the MTD hits as well. This PR limits the function to only the strip detectors.

The problem was found with clang (essentially) complaining the unit test using incorrect overload for HitPattern::appendHit(), and adding asserts in addition to the printouts (that would have indicated the problem of wrong overload already in #9959, and the need for an update in #24419).

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_10_4_X.

It involves the following packages:

DataFormats/TrackReco

@cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks.
@gpetruc, @rovere, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix HitPattern::stripHitFilter() #25692

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32843/console Started: 2019/01/25 16:23

[perrotta]

backport of #25692

[cmsbuild]

+1
Tested at: 0a80e58
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25767/32843/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25767/32843/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3153717
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153505
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

+1

for #25767 0a80e58

• the backport is correct. This should be important for all algorithms using the (Phase-2) tracks extended with MTD hits with access to hit pattern (presently, probably just analysis).
• jenkins tests pass and comparisons with the baseline show no differences.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[kpedro88]

@lgray @pmeridian is this PR required for any MTD offline analysis? (or any other reason to have a patch release including it?)

[pmeridian]

Not an issue as we can always check the actual pattern

…

On 29 Jan 2019, at 17:47, Kevin Pedro ***@***.***> wrote: @lgray @pmeridian is this PR required for any MTD offline analysis? (or any other reason to have a patch release including it?) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[fabiocos]

it is not a show-stopper for the production, but for any use of these tracks implying stripHitPattern it might impact. And indeed may packages are recompiled, so it is not practical for a private use...

[pmeridian]

Simply you can start build patch1 which can be used for the analysis, but we do not have to delay the start of the production P.

…

On 30 Jan 2019, at 17:58, Fabio Cossutti ***@***.***> wrote: it is not a show-stopper for the production, but for any use of these tracks implying stripHitPattern it might impact. And indeed may packages are recompiled, so it is not practical for a private use...

[fabiocos]

sure, I will merge it and then we see when to make a build (in case more fixes arrive)

[fabiocos]

+1