Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is HardEventHypothesis class still useful? #29834

Closed
makortel opened this issue May 14, 2020 · 13 comments
Closed

Is HardEventHypothesis class still useful? #29834

makortel opened this issue May 14, 2020 · 13 comments

Comments

@makortel
Copy link
Contributor

While trying to address #29306 and #26618 I came across mkevhyp and


class.

git grep HardEventHypothesis does not show any use in CMSSW beyond the class definition and the Skeletons template. The HardEventHypothesis.h looks like it has not gone through clang-format. Git history shows total of 4 commits, last one from 2013 for removing CVS keywords, and the other 3 from 2008.

Before putting effort into modernizing the template I would like to understand if this class is still useful. If not, I would really like to remove it, or at least the Skeletons template.

@cmsbuild
Copy link
Contributor

A new Issue was created by @makortel Matti Kortelainen.

@Dr15Jones, @silviodonato, @dpiparo, @smuzaffar, @makortel can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

assign reconstruction, analysis

@cmsbuild
Copy link
Contributor

New categories assigned: analysis,reconstruction

@slava77,@santocch,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

@makortel makortel changed the title Is HardEventHypothesis still useful? Is HardEventHypothesis class still useful? May 14, 2020
@perrotta
Copy link
Contributor

At a first glance it could even safely get removed
Let however add @rappoccio in the discussion , who was the original author of it

@makortel
Copy link
Contributor Author

Thanks @perrotta, I will then remove the mkevhyp and related skeleton, and leave the removal of DataFormats/PatCandidates/interface/HardEventHypothesis.h to a separate PR.

@santocch
Copy link

+1
OK to proceed as @makortel propose

@makortel
Copy link
Contributor Author

I will then remove the mkevhyp and related skeleton,

Done as part of #29840.

@rappoccio
Copy link
Contributor

Wow, this is 12+ years old, I entirely forgot about it. It has no purpose anymore and can be removed.

@makortel
Copy link
Contributor Author

Thanks for the confirmation @rappoccio.

@perrotta
Copy link
Contributor

Created PR #29903 to remove the HardEventHypothesis class from CMSSW

@perrotta
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

@makortel
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants