Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should GeomDet be in DataFormats rather than Geometry? #31252

Closed
davidlange6 opened this issue Aug 26, 2020 · 9 comments
Closed

Should GeomDet be in DataFormats rather than Geometry? #31252

davidlange6 opened this issue Aug 26, 2020 · 9 comments
Labels
fully-signed geometry-approved

Comments

@davidlange6
Copy link
Contributor

Among the violations of dependencies in DataFormats is the use of GeomDet. This has created a cyclic dependency in module 'GeometryCommonTopologies': GeometryCommonTopologies -> DataFormatsTrackingRecHit -> GeometryCommonTopologies

which I'd like to break..
@cmsbuild
Copy link
Contributor

A new Issue was created by @davidlange6 David Lange.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor Author

assign geometry

@cmsbuild
Copy link
Contributor

New categories assigned: geometry

@Dr15Jones,@cvuosalo,@mdhildreth,@makortel,@ianna,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

@Dr15Jones
Copy link
Contributor

My personal take is why does Geometry depend on TrackingRecHit?

@Dr15Jones
Copy link
Contributor

The answer is

cdj@mac-131265> git grep '#include "DataFormats/TrackingRecHit' | grep "Geometry/CommonTopologies"
Geometry/CommonTopologies/interface/GeometryAligner.h:#include "DataFormats/TrackingRecHit/interface/AlignmentPositionError.h"
Geometry/CommonTopologies/src/GeomDet.cc:#include "DataFormats/TrackingRecHit/interface/AlignmentPositionError.h"
Geometry/CommonTopologies/src/TrackerGeomDet.cc:#include "DataFormats/TrackingRecHit/interface/AlignmentPositionError.h"

So my take is DataFormats/TrackingRecHit/interface/AlignmentPositionError.h should move to Geometry/CommonTopologies.

@davidlange6
Copy link
Contributor Author

davidlange6 commented Aug 26, 2020 via email

@slava77
Copy link
Contributor

slava77 commented Aug 26, 2020 •
edited

So my take is DataFormats/TrackingRecHit/interface/AlignmentPositionError.h should move to Geometry/CommonTopologies.

perhaps DataFormats/GeometryCommonDetAlgo
because in DataFormats/TrackingRecHit/interface/AlignmentPositionError.h

#include "DataFormats/GeometryCommonDetAlgo/interface/GlobalError.h"

is the only include

@davidlange6 davidlange6 mentioned this issue Aug 27, 2020
Merged
@cvuosalo
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fully-signed geometry-approved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Dr15Jones @cmsbuild @slava77 @davidlange6 @cvuosalo