Complete migration of FastSim modules to esConsumes

[perrotta]

As pointed out in the thread discussion of #35056, FamosManager is used only by FamosProducer, and FamosProducer is not being run in IBs (with git grep I see FamosProducer being used only in FastSimulation/EventProducer/python/FamosSimHits_cff.py that itself is not imported anywhere).

For that reason, these (and other) FastSim modules still need to be fully migrated to esConsumes.

@cms-sw/fastsim-l2 please have a look at the modules listed below [1] and either remove them or finalize their migration to esConsumes

[1] For the record:

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-1100/src/FastSimulation/EventProducer/src/FamosManager.cc:101:3: warning: function 'FamosManager::setupGeometryAndField' calls function 'edm::eventsetup::EventSetupRecord::get<edm::ESHandle<GeometricSearchTracker> >' with argument of type 'const std::string' with argument of type 'edm::ESHandle<GeometricSearchTracker>'. Direct call of function EventSetupRecord::get(ESHandle&) is deprecated and should be replaced with a call to EventSetup::getHandle(ESGetToken&). To use ESGetToken see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#In_ED_module To get data with the token see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit [deprecated.ESRecordGetChecker]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-1100/src/FastSimulation/EventProducer/src/FamosManager.cc:105:3: warning: function 'FamosManager::setupGeometryAndField' calls function 'edm::eventsetup::EventSetupRecord::get<edm::ESHandle<TrackerInteractionGeometry> >' with argument of type 'const std::string' with argument of type 'edm::ESHandle<TrackerInteractionGeometry>'. Direct call of function EventSetupRecord::get(ESHandle&) is deprecated and should be replaced with a call to EventSetup::getHandle(ESGetToken&). To use ESGetToken see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#In_ED_module To get data with the token see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit [deprecated.ESRecordGetChecker]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-1100/src/FastSimulation/EventProducer/src/FamosManager.cc:111:5: warning: function 'FamosManager::setupGeometryAndField' calls function 'edm::eventsetup::EventSetupRecord::get<edm::ESHandle<MagneticFieldMap> >' with argument of type 'const std::string' with argument of type 'edm::ESHandle<MagneticFieldMap>'. Direct call of function EventSetupRecord::get(ESHandle&) is deprecated and should be replaced with a call to EventSetup::getHandle(ESGetToken&). To use ESGetToken see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#In_ED_module To get data with the token see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit [deprecated.ESRecordGetChecker]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-1100/src/FastSimulation/EventProducer/src/FamosManager.cc:126:5: warning: function 'FamosManager::setupGeometryAndField' calls function 'edm::eventsetup::EventSetupRecord::get<edm::ESHandle<CaloGeometry> >' with argument of type 'edm::ESHandle<CaloGeometry>'. Direct call of function EventSetupRecord::get(ESHandle&) is deprecated and should be replaced with a call to EventSetup::getHandle(ESGetToken&). To use ESGetToken see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#In_ED_module To get data with the token see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit [deprecated.ESRecordGetChecker]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-1100/src/FastSimulation/EventProducer/src/FamosManager.cc:130:5: warning: function 'FamosManager::setupGeometryAndField' calls function 'edm::eventsetup::EventSetupRecord::get<edm::ESHandle<CaloTopology> >' with argument of type 'edm::ESHandle<CaloTopology>'. Direct call of function EventSetupRecord::get(ESHandle&) is deprecated and should be replaced with a call to EventSetup::getHandle(ESGetToken&). To use ESGetToken see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#In_ED_module To get data with the token see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit [deprecated.ESRecordGetChecker]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-1100/src/FastSimulation/EventProducer/src/FamosManager.cc:94:3: warning: function 'FamosManager::setupGeometryAndField' calls function 'edm::eventsetup::EventSetupRecord::get<edm::ESHandle<TrackerGeometry> >' with argument of type 'const std::string' with argument of type 'edm::ESHandle<TrackerGeometry>'. Direct call of function EventSetupRecord::get(ESHandle&) is deprecated and should be replaced with a call to EventSetup::getHandle(ESGetToken&). To use ESGetToken see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#In_ED_module To get data with the token see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit [deprecated.ESRecordGetChecker]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-1100/src/FastSimulation/EventProducer/src/FamosProducer.cc:68:3: warning: function 'FamosProducer::produce' calls function 'edm::eventsetup::EventSetupRecord::get<edm::ESHandle<TrackerTopology> >' with argument of type 'edm::ESHandle<TrackerTopology>'. Direct call of function EventSetupRecord::get(ESHandle&) is deprecated and should be replaced with a call to EventSetup::getHandle(ESGetToken&). To use ESGetToken see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#In_ED_module To get data with the token see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit [deprecated.ESRecordGetChecker]

[perrotta]

assign fastsim

[cmsbuild]

A new Issue was created by @perrotta Andrea Perrotta.

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[cmsbuild]

New categories assigned: fastsim

@civanch,@sbein,@ssekmen,@mdhildreth,@lveldere you have been requested to review this Pull request/Issue and eventually sign? Thanks

[sbein]

Hi @perrotta sorry for my delayed reply. I had to review the changes a few times in #35056. It looks ok, like mostly just the small coding tweaks for the migration consistent with

https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit

Is there anything else that needs to be modified here, or is approving this the last step?

[makortel]

The question of this issue is mainly about FamosManager and FamosProducer that were not migrated in #35056 because they appear to be unused. They should be either migrated or removed.

[sbein]

Ok a pull request has been opened for the removal of the Famos producer/manager, its associated package, and no-longer usable config file:
#35352

[perrotta]

Fixed by #35352
See #35243 (comment)