Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback information not propagated to StatisticsSenderService #36375

Closed
makortel opened this issue Dec 6, 2021 · 6 comments · Fixed by #36379
Closed

Fallback information not propagated to StatisticsSenderService #36375

makortel opened this issue Dec 6, 2021 · 6 comments · Fixed by #36379

Comments

@makortel
Copy link
Contributor

makortel commented Dec 6, 2021

While investigating a question of @perrotta in #36358 (comment) I realized that after #28911 the RootInputFileSequence::usedFallback_ was no longer set, and consequently StatisticsSenderService was no longer reporting this information in

if (usedFallback) {
os << "\"fallback\": true, ";
}

(also Tracer attempts to use the usedFallback information e.g. in

void Tracer::preOpenFile(std::string const& lfn, bool b) {
LogAbsolute out("Tracer");
out << TimeStamper(printTimestamps_);
out << indention_ << indention_ << " starting: open input file: lfn = " << lfn;
if (dumpNonModuleContext_)
out << " usedFallBack = " << b;
}
)

@makortel
Copy link
Contributor Author

makortel commented Dec 6, 2021

assign core

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2021

New categories assigned: core

@Dr15Jones,@smuzaffar,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2021

A new Issue was created by @makortel Matti Kortelainen.

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Dec 6, 2021

Fixed in #36379

@makortel
Copy link
Contributor Author

makortel commented Dec 7, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2021

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants