Possible bug in Validation/RecoVertex/src/BeamSpotHistogramMaker.cc

[perrotta]

As pointed out by the static analyzer, the value stored in currdir at L29 of Validation/RecoVertex/src/BeamSpotHistogramMaker.cc in the BeamSpotHistogramMaker::book method is never read.

Shouldn't that line be written as

    _currdir = &(tfserv->tFileDirectory());

instead? (With _currdir instead of currdir)

[perrotta]

assign dqm

[cmsbuild]

New categories assigned: dqm

@jfernan2,@ahmad3213,@rvenditti,@emanueleusai,@pbo0,@pmandrik you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

A new Issue was created by @perrotta Andrea Perrotta.

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[jfernan2]

Thanks @perrotta
I believe you are totally right, of course.
I have fixed it in:
#36656

[perrotta]

Fixed by #36656, thank you @jfernan2

[jfernan2]

+1
For the records

[cmsbuild]

This issue is fully signed and ready to be closed.