[LTO_X - Calibration/HcalAlCaRecoProducers] -Wodr compiler warnings #38656
Labels
Comments
|
A new Issue was created by @aandvalenzuela Andrea Valenzuela. @Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
|
assign alca |
|
New categories assigned: alca @yuanchao,@francescobrivio,@malbouis,@tvami,@ChrisMisan you have been requested to review this Pull request/Issue and eventually sign? Thanks |
|
@bsunanda please have a look at this issue, thanks! |
|
OK - I shall. Just a question - what is the coding rule for name of a NameSpace should the first letter be Capital or could it be small as well? |
|
"For namespaces use lower case, e.g. namespace edm." |
bsunanda
pushed a commit
to bsunanda/cmssw
that referenced
this issue
Jul 9, 2022
|
Pleas see if #38662 can resolve this issue |
bsunanda
pushed a commit
to bsunanda/cmssw
that referenced
this issue
Jul 10, 2022
|
+alca |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This issue is fully signed and ready to be closed. |
cmsbuild
added a commit
that referenced
this issue
Jul 11, 2022
Run3-alca223 Fixes the issue reported in #38656
Michael-Krohn
pushed a commit
to Michael-Krohn/cmssw
that referenced
this issue
Jul 15, 2022
jhakala
pushed a commit
to jhakala/cmssw
that referenced
this issue
Aug 2, 2022
jhakala
pushed a commit
to jhakala/cmssw
that referenced
this issue
Aug 3, 2022
|
Hi @bsunanda, We have seen in recent LTO builds that the Do you think it is something that can be solve as you did in #38662? Please, let me know if you prefer that I open a separate issue for this. Many thanks, |
bsunanda
pushed a commit
to bsunanda/cmssw
that referenced
this issue
Aug 19, 2022
…eported in the issue cms-sw#38656
|
I believe it was not complete. I am submitting a new PR (#39112) for this. Please check this. Sorry
Sunanda
________________________________
From: Andrea Valenzuela ***@***.***
Sent: 19 August 2022 11:33
To: cms-sw/cmssw
Cc: Sunanda Banerjee; Mention
Subject: Re: [cms-sw/cmssw] [LTO_X - Calibration/HcalAlCaRecoProducers] -Wodr compiler warnings (Issue #38656)
Hi @bsunanda<https://github.com/bsunanda>,
We have seen in recent LTO builds that the -Word warning is reappearing for lines 42-22:
> Building edm plugin tmp/el8_amd64_gcc10/src/Calibration/HcalAlCaRecoProducers/plugins/CalibrationHcalAlCaRecoProducersPlugins/libCalibrationHcalAlCaRecoProducersPlugins.so
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_LTO_X_2022-08-16-1100/src/Calibration/HcalAlCaRecoProducers/plugins/AlCaHBHEMuonFilter.cc:42:10: warning: type 'struct Counters' violates the C++ One Definition Rule [-Wodr]
42 | struct Counters {
| ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_LTO_X_2022-08-16-1100/src/Calibration/HcalAlCaRecoProducers/plugins/AlCaHBHEMuonProducer.cc:42:10: note: a different type is defined in another translation unit
42 | struct Counters {
| ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_LTO_X_2022-08-16-1100/src/Calibration/HcalAlCaRecoProducers/plugins/AlCaHBHEMuonFilter.cc:44:54: note: the first difference of corresponding definitions is field 'nFinal_'
44 | mutable std::atomic<unsigned int> nAll_, nGood_, nFinal_;
| ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_LTO_X_2022-08-16-1100/src/Calibration/HcalAlCaRecoProducers/plugins/AlCaHBHEMuonProducer.cc:42:10: note: a type with different number of fields is defined in another translation unit
42 | struct Counters {
| ^
Leaving library rule at src/Calibration/HcalAlCaRecoProducers/plugins
Do you think it is something that can be solve as you did in #38662<#38662>? Please, let me know if you prefer that I open a separate issue for this.
Many thanks,
Andrea.
—
Reply to this email directly, view it on GitHub<#38656 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZORTRERU6L6F5TQ7BLLVZ5IFDANCNFSM53A732OQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
bsunanda
pushed a commit
to bsunanda/cmssw
that referenced
this issue
Aug 19, 2022
…eported in the issue cms-sw#38656 Code check
bsunanda
pushed a commit
to bsunanda/cmssw
that referenced
this issue
Aug 19, 2022
…eported in the issue cms-sw#38656 Code check Remove the change for AlCaIsolatedBunchSelector
cmsbuild
added a commit
that referenced
this issue
Aug 22, 2022
Run3-alca227 Try to avoid LTO warnings from Calibration/HcalAlCaRecoProducers as reported in the issue #38656
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
We have seen some compiler warnings of the type
-Wodrin LTO_X IBs (CMSSW_12_5_LTO_X_2022-07-07-1100 and CMSSW_12_5_LTO_X_2022-07-06-1100, for example) in packageCalibration/HcalAlCaRecoProducers. See sample stack trace:This warning is also shown in other packages, such as reported in #38650. It seems there are some elements defined multiple times within the same namespace leading to violation of the C++ One Definition Rule. Could you please have a look at it?
Many thanks,
Andrea.
The text was updated successfully, but these errors were encountered: