Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BeamSpotOnline tags to the Prompt GT #41459

Closed
francescobrivio opened this issue Apr 28, 2023 · 10 comments
Closed

Add BeamSpotOnline tags to the Prompt GT #41459

francescobrivio opened this issue Apr 28, 2023 · 10 comments

Comments

@francescobrivio
Copy link
Contributor

Description

As reported in Issue#41456, the BeamSpotFromDB is one of the main offenders concerning the LogErrors and LogWarning emitted during Prompt reco.

Solution

As nicely debugged by @mmusich in #41456 (comment), and after some private discussion, it was decided that the best way to fix this is to include the BeamSpotOnline tags (which are already present in the HLT/Express GTs) in the Prompt GT:

FYI @gennai @dzuolo

@francescobrivio
Copy link
Contributor Author

assign alca,db

@cmsbuild
Copy link
Contributor

New categories assigned: db,alca

@francescobrivio,@francescobrivio,@saumyaphor4252,@saumyaphor4252,@tvami,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

A new Issue was created by @francescobrivio .

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Apr 28, 2023

It's a bit counterintuitive to add HLT tags to the Prompt GT. Was this decided so there is no need for code changes (which I guess would be the more intuitive solution)?

@mmusich
Copy link
Contributor

mmusich commented Apr 28, 2023

Was this decided so there is no need for code changes

The need of adding the HLT tags originates from the need of monitoring in prompt the difference between the online and offline beamspots.
When in Run2 the online BS was saved in the scalers RAW data, there was no need for that. Now that the arbitration mechanism at HLT uses the online tags that's the only reliable way to get the information as consumed online.
The alternative of course is dropping the monitoring (which I am not super keen about) or find a different mechanism to save post-facto the onlineBS (suggestions are welcome).

@francescobrivio
Copy link
Contributor Author

francescobrivio commented Apr 28, 2023

The need of adding the HLT tags originates from the need of monitoring in prompt the difference between the online and offline beamspots. When in Run2 the online BS was saved in the scalers RAW data, there was no need for that. Now that the arbitration mechanism at HLT uses the online tags that's the only reliable way to get the information as consumed online. The alternative of course is dropping the monitoring (which I am not super keen about) or find a different mechanism to save post-facto the onlineBS (suggestions are welcome).

Thanks Marco, indeed in the description I forgot to mention that this will restore the possibility to monitor in prompt the difference between online and PCL/offline.

@mmusich
Copy link
Contributor

mmusich commented May 9, 2023

being tested in dmwm/T0#4817

@mmusich
Copy link
Contributor

mmusich commented May 12, 2023

This issue is ready to be signed (and closed).

@francescobrivio
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants