Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM/Integration unit tests employing streamer files in input are silently broken #45224

Closed
mmusich opened this issue Jun 14, 2024 · 5 comments · Fixed by #45231
Closed

DQM/Integration unit tests employing streamer files in input are silently broken #45224

mmusich opened this issue Jun 14, 2024 · 5 comments · Fixed by #45231

Comments

@mmusich
Copy link
Contributor

mmusich commented Jun 14, 2024

This issue is linked to #43108

After PR #44892 was merged, all the DQM/Integration unit tests employing streamer files in input are silently broken due to the change of the streamer layout, with errors of the type:

14-Jun-2024 04:54:51 CEST  Can't deserialize registry data (in open file): An exception of category 'FatalRootError' occurred.
   Additional Info:
      [a] Fatal Root Error: @SUB=TBufferFile::ReadClassBuffer
Could not find the StreamerInfo for version 11 of the class edm::SendJobHeader, object skipped at offset 33

This entails the following tests:

  • TestDQMOnlineClient-beamhlt_dqm_sourceclient
  • TestDQMOnlineClient-beamhlt_dqm_sourceclient-legacy
  • TestDQMOnlineClient-ecalgpu_dqm_sourceclient
  • TestDQMOnlineClient-hcalgpu_dqm_sourceclient
  • TestDQMOnlineClient-pixelgpu_dqm_sourceclient

As reported in #44892 (comment) the reason why the test technically still succeed despite the failures in de-serializing is due to feature of the DQMStreamerReader (see discussion at #43108 (comment)).

A proposed (#44892 (comment)) solution would entail:

Alternatively in #44892 (comment), it was proposed to create new "artificial" streamer file from scratch using the new release, where the files contains known data values and the unit tests show that those values are what is there when read.

Cc: @francescobrivio @nothingface0

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 14, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Issue was created by @mmusich.

@Dr15Jones, @makortel, @sextonkennedy, @antoniovilela, @smuzaffar, @rappoccio can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jun 14, 2024

assign dqm

@cmsbuild
Copy link
Contributor

New categories assigned: dqm

@rvenditti,@syuvivida,@tjavaid,@nothingface0,@antoniovagnerini you have been requested to review this Pull request/Issue and eventually sign? Thanks

@mmusich
Copy link
Contributor Author

mmusich commented Jun 15, 2024

this is fixed at #45231 + cms-data/DQM-Integration#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants