Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vtx smearing parameters: nominal beam parameters, realistic centroid #10048

Merged
merged 3 commits into from
Jul 10, 2015
Merged

Add vtx smearing parameters: nominal beam parameters, realistic centroid #10048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bec9a69
add vtx smearing parameters for nominal beam size but realistic (meas…
rmanzoni Jul 6, 2015
657f68c
Merge remote-tracking branch 'cms/CMSSW_7_6_X' into CMSSW_7_6_X_vtx_s…
rmanzoni Jul 8, 2015
d1fd2b9
fix naming
rmanzoni Jul 8, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion Configuration/StandardSequences/python/VtxSmeared.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@
'Shifted15mmCollision2015' : 'IOMC.EventVertexGenerators.VtxSmearedShifted15mmCollision2015_cfi',
'NominalCollision2015' : 'IOMC.EventVertexGenerators.VtxSmearedNominalCollision2015_cfi',
'NominalHICollision2015': 'IOMC.EventVertexGenerators.VtxSmearedNominalHICollision2015_cfi',
'ZeroTeslaRun247324Collision' : 'IOMC.EventVertexGenerators.VtxSmearedZeroTeslaRun247324Collision_cfi'
'ZeroTeslaRun247324Collision' : 'IOMC.EventVertexGenerators.VtxSmearedZeroTeslaRun247324Collision_cfi',
'Realistic50ns13TeVCollision': 'IOMC.EventVertexGenerators.VtxSmearedRealistic50ns13TeVCollision_cfi',

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for my slow query here. I don't like the name, as it will be wrong pretty soon. Could we again identify it with a name such as VtxSmearedNominal2015_cfi (or perhaps with 50ns also in the name)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidlange6 proposal from Marco and us: Realistic50ns13TeVCollisions
Would you sign off on this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmanzoni
ok for me - though I'm not sure why you propose to change VtxSmeared (as in all beamspots) to Realistic. Could you clarify?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, what I wrote was probably confusing and the fact that in the current PR I forgot by mistake to add VtxSmeared didn't help.

I am changing the name and fixing the typo, it'll eventually read
'Realistic50ns13TeVCollision':'IOMC.EventVertexGenerators.VtxSmearedRealistic50ns13TeVCollision_cfi',

I'll propagate the fix to the other PRs as well.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ciao Riccardo @rmanzoni ,
while I can't decide for @davidlange6 ,
I would personally find Realistic50ns13TeVCollisions much better and would be happy to sing it (as operations).
May I suggest you proceed with the renaming, so I can do a last round of tests ?

}
VtxSmearedDefaultKey='NominalCollision2015'
VtxSmearedHIDefaultKey='NominalHICollision2015'
11 changes: 11 additions & 0 deletions IOMC/EventVertexGenerators/python/VtxSmearedParameters_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,17 @@
Y0 = cms.double(0.1657),
Z0 = cms.double(-1.688)
)
Realistic50ns13TeVCollisionVtxSmearingParameters = cms.PSet(
Phi = cms.double(0.0),
BetaStar = cms.double(65.0),
Emittance = cms.double(5.411e-08),
Alpha = cms.double(0.0),
SigmaZ = cms.double(5.3),
TimeOffset = cms.double(0.0),
X0 = cms.double(0.06006),
Y0 = cms.double(0.10007),
Z0 = cms.double(-1.708)
)
# Test HF offset
ShiftedCollision2015VtxSmearingParameters = cms.PSet(
Phi = cms.double(0.0),
Expand Down
7 changes: 7 additions & 0 deletions IOMC/EventVertexGenerators/python/VtxSmearedRealistic50ns13TeVCollision_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import FWCore.ParameterSet.Config as cms

from IOMC.EventVertexGenerators.VtxSmearedParameters_cfi import *
VtxSmeared = cms.EDProducer("BetafuncEvtVtxGenerator",
Realistic50ns13TeVCollisionVtxSmearingParameters,
VtxSmearedCommon
)