Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix in HLT b-tag validation code (75X) #10052

Merged
merged 3 commits into from Jul 9, 2015

Conversation

silviodonato
Copy link
Contributor

This PR fixes:

  • setEfficiencyFlag() option for mistag vs efficiency plots
  • trigger name HLT_PFMET120_NoiseCleaned_BTagCSV07_v -> HLT_PFMET120_NoiseCleaned_BTagCSV0p72_v
  • trigger name HLT_CaloMHTNoPU90_PFMET90_PFMHT90_IDLoose_ -> HLT_CaloMHTNoPU90_PFMET90_PFMHT90_IDTight_

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2015

A new Pull Request was created by @silviodonato for CMSSW_7_5_X.

Small fix in HLT b-tag validation code (75X)

It involves the following packages:

HLTriggerOffline/Btag

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jul 8, 2015

please test

@deguio
Copy link
Contributor

deguio commented Jul 8, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10052/10963/summary.html

There are some workflows for which there are errors in the baseline:
25202.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

ibooker.book1D(effName.c_str(),eff);
MonitorElement *me;
me = ibooker.book1D(effName.c_str(),eff);
me->setEfficiencyFlag();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be deleted?

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants