New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
back port of pixel lumi dqm from 76X to 75X #10074
back port of pixel lumi dqm from 76X to 75X #10074
Conversation
A new Pull Request was created by @mojoe137 (Pat Kenny) for CMSSW_7_5_X. back port of pixel lumi dqm from 76X to 75X It involves the following packages: DQM/Integration The following packages do not have a category, yet: DQM/PixelLumi @cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks. |
status:
[1] if you want to be more specific, you can OR things: |
-1 |
@cmsbuild, please test (new commits here) |
please test |
The tests are being triggered in jenkins. |
+1 |
float(nFMClus[i])/float(all_detectors_counts)); | ||
} | ||
|
||
logFile_.open(fLogFileName_.c_str(),std::ios_base::trunc); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this log file needs to be made optional and off by default. thx
thanks @davidlange6 for the catch. |
@deguio @davidlange6, Sorry for the slow replay. I asked around a little bit about this log file. Apparently it is what is read by the wbm. I need to check if it's been put in the write place, but I do want to keep it. I could add a config parameter to turn it off though. |
back port of pixel lumi dqm from 76X to 75X
this is back port of this pull request: #10007