Fixing of bunchspacing handling in the SipixelDigitizer Dynamic Inefficiency in 75X

[bartokm]

Fixing the code of treating every bunchspace value as default (25ns) except when bunchspace == 50ns. The problem came up with the HI configurations where they use "bunchspace = 1". For the HI global tag @diguida and @mmusich will upload a trivial (flat) inefficiency payload.

A similar PR is done in 76X.

[cmsbuild]

A new Pull Request was created by @bartokm for CMSSW_7_5_X.

Fixing of bunchspacing handling in the SipixelDigitizer Dynamic Inefficiency in 75X

It involves the following packages:

SimGeneral/DataMixingModule
SimTracker/SiPixelDigitizer

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@wmtan, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @dkotlins, @cerati, @threus, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1
Tested at: 3a5fc07
you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10082/10955/summary.html

[cmsbuild]

+1
Tested at: 3a5fc07
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10082/120/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10082/120/summary.html