Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update track candidate DQM code #10125

Merged
merged 10 commits into from Aug 8, 2015
Merged

update track candidate DQM code #10125

merged 10 commits into from Aug 8, 2015

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Jul 10, 2015

as requested by Vincenzo and reported in the JIRA ticket https://its.cern.ch/jira/browse/CMSTRACK-136

  • add track candidate phi vs eta
  • switch on track candidate monitoring in the config run on Express and Prompt Reco
  • add missing step jetCoreRegionalStep

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Jul 10, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_5_X.

update track candidate DQM code

It involves the following packages:

DQM/TrackingMonitor
DQM/TrackingMonitorSource

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@makortel, @threus this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jul 10, 2015

ciao mia,
please submit for 76 as well.
thanks,
F.

@deguio
Copy link
Contributor

deguio commented Jul 10, 2015

please test

@mtosi mtosi mentioned this pull request Jul 10, 2015
Merged
@cmsbuild
Copy link
Contributor

Pull request #10125 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again.

mtosi added a commit to mtosi/cmssw that referenced this pull request Jul 10, 2015
@mtosi
backport PR cms-sw#10125
fb17111
@mtosi mtosi mentioned this pull request Jul 10, 2015
Merged
@mtosi
Copy link
Contributor Author

mtosi commented Jul 13, 2015

sorry, I forgot to delete one line in a file,
now it should work

@cmsbuild
Copy link
Contributor

Pull request #10125 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Jul 13, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10125/6923/summary.html

slava77
slava77 reviewed Aug 3, 2015
View reviewed changes
RecoTracker/Configuration/python/customiseForRunI.py
@@ -109,4 +109,14 @@ def customiseForRunI(process):
process.SiStripClusterChargeCutTight.value = -1.
process.SiStripClusterChargeCutLoose.value = -1.


if hasattr(process, 'TrackingDQMSourceTier0Common') and 'TrackSeedMonjetCoreRegionalStep' in process.TrackingDQMSourceTier0Common.moduleNames():
process.TrackingDQMSourceTier0Common.remove(process.TrackSeedMonjetCoreRegionalStep)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there could have been a more elegant way that doesn't introduce "DQM" into pure Reco configs.

@deguio
Copy link
Contributor

deguio commented Aug 5, 2015

+1
equivalent of #10373 + #10126

@cvuosalo
Copy link
Contributor

cvuosalo commented Aug 7, 2015

+1

For #10125 14201ea

Adding some tracking DQM plots. There should be no change in other monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-08-02-2300 show no significant differences, as expected. Checking T0 configs shows the new code doesn't introduce any configuration problems.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 8, 2015
@cmsbuild
Merge pull request #10125 from mtosi/from-CMSSW_7_5_0_pre6_addTrackCa…
70b1697 
…ndidatePHIvsETA

update track candidate DQM code
@cmsbuild cmsbuild merged commit 70b1697 into cms-sw:CMSSW_7_5_X Aug 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mtosi @cmsbuild @deguio @rovere @slava77 @cvuosalo @davidlange6