Replace leaking code with boost counterpart. #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktf
added a commit
that referenced
this pull request
Oct 8, 2013
Remove leaking code with boost counterpart.
|
@mulhearn I accidentally merged this without your approval, it's quite trivial though. Can you cross check please? |
|
Looking... |
|
It looks fine. This function is not used directly by any code in CMSSW. Instead it is used to produce header files during code development. So there is no existing test in CMSSW, but I did check that the boost routine exactly reproduces the home-brew function in a simple test executable. |
mcepeda
pushed a commit
to mcepeda/cmssw
that referenced
this pull request
Jun 7, 2022
Update trackjet simulation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.