Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

75X ExoLL and FSPremix dictionary #10154

Merged
merged 2 commits into from Jul 19, 2015
Merged

Conversation

srimanob
Copy link
Contributor

(1) Add ExoLL relval
(2) Fix FSPremix Dictionary

@srimanob
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Jul 11, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob (Phat Srimanobhas) for CMSSW_7_5_X.

75X ExoLL and FSPremix dictionary

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @srimanob, @boudoul, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@davidlange6
Copy link
Contributor

looks like this is causing problems.. maybe because of the forward port from 75x? I will revert.

@franzoni
Copy link

Hello David @davidlange6 ,
can you please indicate to us what the problem is ?
Nothing obvious looking at https://cms-sw.github.io/relvalLogDetail.html#slc6_amd64_gcc491;CMSSW_7_5_X_2015-07-19-1100
where I see this PR was already merged.
Thanks,
G.

@davidlange6
Copy link
Contributor

i think if you run runTheMatrix.py you’ll see the problem

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10232/11319/runTheMatrix-results/matrixTests.log

the same change to add this susy workflow was made in a different place (and different commit/PR) for 75x

On Jul 20, 2015, at 3:08 PM, Giovanni Franzoni notifications@github.com wrote:

Hello David @davidlange6 ,
can you please indicate to us what the problem is ?
Nothing obvious looking at https://cms-sw.github.io/relvalLogDetail.html#slc6_amd64_gcc491;CMSSW_7_5_X_2015-07-19-1100
where I see this PR was already merged.
Thanks,
G.


Reply to this email directly or view it on GitHub.

@davidlange6
Copy link
Contributor

but to clarify - the problem is in 76x, not 75x. - so my revert is not perfect as it removes the change from both 75x and 76x.

On Jul 20, 2015, at 3:13 PM, David Lange David.Lange@cern.ch wrote:

i think if you run runTheMatrix.py you’ll see the problem

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10232/11319/runTheMatrix-results/matrixTests.log

the same change to add this susy workflow was made in a different place (and different commit/PR) for 75x

On Jul 20, 2015, at 3:08 PM, Giovanni Franzoni notifications@github.com wrote:

Hello David @davidlange6 ,
can you please indicate to us what the problem is ?
Nothing obvious looking at https://cms-sw.github.io/relvalLogDetail.html#slc6_amd64_gcc491;CMSSW_7_5_X_2015-07-19-1100
where I see this PR was already merged.
Thanks,
G.


Reply to this email directly or view it on GitHub.

@srimanob
Copy link
Contributor Author

What should I do with this one? Make it from clean scratch of IB that will come out with #10279?

@davidlange6
Copy link
Contributor

Yes. And cherry-pick your 76x version to avoid conflicts.

On Jul 20, 2015, at 3:23 PM, Phat Srimanobhas <notifications@github.commailto:notifications@github.com> wrote:

What should I do with this one? Make it from clean scratch of IB that will come out with #10279#10279?


Reply to this email directly or view it on GitHubhttps://github.com//pull/10154#issuecomment-122881802.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants