Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing CSV+SL and adding SL taggers to the default PAT jet configuration #10157

Conversation

ferencek
Copy link
Contributor

Given the fact that the CombinedMVA tagger uses SL tagger discriminators as input, it would be beneficial to also have SL taggers stored in MiniAOD to speed up and simplify any future retrainings of ''supercombined" taggers.

@pvmulder @imarches @acaudron

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_5_X.

Removing CSV+SL and adding SL taggers to the default PAT jet configuration

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@monttj
Copy link
Contributor

monttj commented Jul 13, 2015

@ferencek
I am just curious that we are not using "pfCombinedSecondaryVertexSoftLeptonBJetTags" tagger at the analysis level ?

@monttj
Copy link
Contributor

monttj commented Jul 13, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@ferencek
Copy link
Contributor Author

@monttj, studies of the performance of CSV+SL indicated there are some not fully understood features in its training (@pvmulder can confirm) and that in the end better performance is obtained from pfCombinedMVABJetTags. The main difference between the two is that CSV+SL takes as input all of the input variables of the CSVv2 tagger and the soft lepton (SL) taggers while pfCombinedMVABJetTags takes as input the output disciminators from the JP, CSVv2, and SL taggers.

@monttj
Copy link
Contributor

monttj commented Jul 29, 2015

+1

@monttj
Copy link
Contributor

monttj commented Jul 29, 2015

@ferencek thank you!

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 2, 2015
…_from-CMSSW_7_5_0_pre6

Removing CSV+SL and adding SL taggers to the default PAT jet configuration
@cmsbuild cmsbuild merged commit 38dc6e0 into cms-sw:CMSSW_7_5_X Aug 2, 2015
@ferencek ferencek deleted the SoftLeptonTaggersInMiniAOD_from-CMSSW_7_5_0_pre6 branch August 2, 2015 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants