Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RelVals for PCL (75X) #10169

Merged
merged 2 commits into from Aug 10, 2015
Merged

RelVals for PCL (75X) #10169

merged 2 commits into from Aug 10, 2015

Conversation

cerminar
Copy link
Contributor

Add all the PCL workflows currently in production to the relval matrix.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cerminar for CMSSW_7_6_X.

RelVals for PCL (75X)

It involves the following packages:

Configuration/AlCa
Configuration/PyReleaseValidation

@diguida, @boudoul, @franzoni, @cerminar, @cmsbuild, @srimanob, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@franzoni
Copy link

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: 340b69d
When I ran the RelVals I found an error in the following worklfows:
135.4 step3

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step3_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

1306.0 step5

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step5_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log

1330.0 step5

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step5_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log

4.53 step5

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT/step5_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT.log

50202.0 step5

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550/step5_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550.log

25202.0 step5

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15/step5_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10169/8672/summary.html

@franzoni
Copy link

+1
locally tested on 5 events
running first relval franzoni_RVCMSSW_7_6_0_pre1RunMinBias2011A__RelVal_mb2011A_150720_231121_1

@davidlange6
Copy link
Contributor

@mmusich @diguida - is something needed before accepting this PR?

@mmusich
Copy link
Contributor

mmusich commented Aug 10, 2015

+1
@davidlange6 there are fixes in the pipeline, will be applied in the next iteration

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@boudoul
Copy link
Contributor

boudoul commented Aug 10, 2015

@mmusich , is there are fix in the pipeline, should we postpone the integration of this PR ? (I see that you signed it , but was wondering due to your comment about the fix at the same time)

@mmusich
Copy link
Contributor

mmusich commented Aug 10, 2015

@boudoul, they are unrelated to this PR, it's important that at least these changes get into release. Since we are discussing here, could you please also sign these other ones: #10449 and #10451?

@boudoul
Copy link
Contributor

boudoul commented Aug 10, 2015

ok I will just relaunch a test as the previous ones were quite old, and sign eventually

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 10, 2015
@cmsbuild cmsbuild merged commit ed7fc8e into cms-sw:CMSSW_7_6_X Aug 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants