Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3dhit hlt #1019

Closed
wants to merge 11 commits into from
Closed

3dhit hlt #1019

wants to merge 11 commits into from

Conversation

tropiano
Copy link
Contributor

@tropiano tropiano commented Oct 8, 2013

added the possibility to cut on 3d hits at HLT.
Bug fix wrt pull request #1017.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2013

A new Pull Request was created by @tropiano for CMSSW_7_0_X.

3dhit hlt

It involves the following packages:

RecoTracker/FinalTrackSelectors

@nclopezo, @smuzaffar, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @gpetruc, @GiacomoSguazzoni, @rovere, @cerati this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@nclopezo
Copy link
Contributor

nclopezo commented Oct 9, 2013

-1
I ran the usual tests and when I ran the RelVals and I got the following error in worklfow 4.53 step2, and similar errors in the other workflows.

globaltag = PRE_P62_V8::All
271 DQMStore::DQMStore 
08-Oct-2013 17:38:46 CEST  Initiating request to open file root://eoscms//eos/cms/store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root?svcClass=default
08-Oct-2013 17:38:46 CEST  Successfully opened file root://eoscms//eos/cms/store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root?svcClass=default
08-Oct-2013 17:38:55 CEST  Closed file root://eoscms//eos/cms/store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root?svcClass=default
----- Begin Fatal Exception 08-Oct-2013 17:38:55 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=AnalyticalTrackSelector label='hltPFlowTrackSelectionHighPurity'
Exception Message:
MissingParameter: Parameter 'isHLT' not found.
----- End Fatal Exception -------------------------------------------------

you can see the logs here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/844/summary.html

@cerati
Copy link
Contributor

cerati commented Oct 9, 2013

@tropiano, can you make the parameter optional so that if not present it is set to false? in this way you just need to add the parameter to the HLT cfg and offline should run without problems.

g.

On Oct 9, 2013, at 9:41 AM, David Mendez wrote:

-1
I ran the usual tests and when I ran the RelVals and I got the following error in worklfow 4.53 step2, and similar errors in the other workflows.

globaltag = PRE_P62_V8::All
271 DQMStore::DQMStore
08-Oct-2013 17:38:46 CEST Initiating request to open file root://eoscms//eos/cms/store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root?svcClass=default
08-Oct-2013 17:38:46 CEST Successfully opened file root://eoscms//eos/cms/store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root?svcClass=default
08-Oct-2013 17:38:55 CEST Closed file root://eoscms//eos/cms/store/data/Run2012B/SinglePhoton/RAW/v1/000/194/533/1084D9DA-AEA2-E111-B3AB-001D09F24DA8.root?svcClass=default
----- Begin Fatal Exception 08-Oct-2013 17:38:55 CEST-----------------------
An exception of category 'Configuration' occurred while
[0] Constructing the EventProcessor
[1] Constructing module: class=AnalyticalTrackSelector label='hltPFlowTrackSelectionHighPurity'
Exception Message:
MissingParameter: Parameter 'isHLT' not found.
----- End Fatal Exception -------------------------------------------------
you can see the logs here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/844/summary.html


Reply to this email directly or view it on GitHub.

@thspeer
Copy link
Contributor

thspeer commented Oct 9, 2013

Please use existAs to check

@Dr15Jones
Copy link
Contributor

It would be even better to use the ParameterSet validation.

@Martin-Grunewald
Copy link
Contributor

The current HLT configs do not contain this parameter,
so faking it up with a value of false will be wrong for HLT.
The proper way is as usual a new ConfDB parsing which
adds this parameter, and then migrating all to a value of true
and regenerate the dumps.
After the MeasurementTracker mess!

@tropiano
Copy link
Contributor Author

So, I wait after the MeasurementTracker mess (pull request 519) is over and then I will resubmit the request after having checked everything with the ParameterSet validation. Do you refer to this one? https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideConfigurationValidationAndHelp

Thanks,
Antonio

@Dr15Jones
Copy link
Contributor

Yes, that is the documentation.

@tropiano tropiano closed this Oct 14, 2013
@ghost ghost mentioned this pull request Sep 17, 2014
folguera pushed a commit to folguera/cmssw that referenced this pull request May 27, 2022
Drop e/g simulation from L1 emulator sequence and event content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants