New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsunanda:Run2-hcs23 Modify to add the adequate ESProducers in the configuration scenarios #10267
Conversation
A new Pull Request was created by @bsunanda for CMSSW_7_6_X. bsunanda:Run2-hcs23 Modify to add the adequate ESProducers in the configuration scenarios It involves the following packages: Configuration/Geometry @cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks. |
@@ -7,3 +7,5 @@ | |||
from GeometryReaders.XMLIdealGeometryESSource.cmsGeometryDB_cff import * | |||
from Geometry.MuonNumbering.muonNumberingInitialization_cfi import * | |||
from Geometry.TrackerNumberingBuilder.trackerNumbering2023GeometryDB_cfi import * | |||
from Geometry.HcalCommonData.hcalParameters_cfi import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsunanda - this is not needed - the parameters should come from DB
@cmsbuild please test |
The tests are being triggered in jenkins. |
Pull request #10267 was updated. @cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please check and sign again. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
bsunanda:Run2-hcs23 Modify to add the adequate ESProducers in the configuration scenarios
Modify many of the scenarios in COnfiguration/Geometry to add the adequate ESProducers