Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily fix of the offline DQM for the Top PAG (76X) #10271

Merged

Conversation

ebouvier
Copy link

The hltTriggerSummaryRAW is not available on run II data. This PR enables to fill at least purely RECO distributions (currently, no distributions are filled, the code returns because of the missing collection).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ebouvier for CMSSW_7_6_X.

Temporarily fix of the offline DQM for the Top PAG (76X)

It involves the following packages:

DQMOffline/Trigger

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@rociovilar, @trocino, @jhgoh, @battibass this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jul 21, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

@ebouvier - why is this "temporary?

@ebouvier
Copy link
Author

Dear @davidlange6,
This PR avoid that the code returns when the hltTriggerSummaryRAW collection is not found (on run II data) so that at least distributions at the purely RECO level are filled. To fill the distributions comparing HLT to RECO objects, one would need to use the hltTriggerSummaryAOD collection, which implies big changes. Soureek will need some time to find a smart way to implement these changes and we need the DQM GUI to work in the meanwhile.
Cheers.

@ebouvier
Copy link
Author

Dear @deguio and @Degano,
Could you please have a look at this PR and also #10270 and #10269 ?
Thanks !

@deguio
Copy link
Contributor

deguio commented Jul 23, 2015

I will, eventually....
F.

@deguio
Copy link
Contributor

deguio commented Jul 23, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants