Make statics value visible inline to avoid possible race conditions and #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subsequent clang static analyzer complains. These should really be a constexpr, but we cannot do it until ROOT6.
|
A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_0_X. Make statics value visible inline to avoid possible race conditions and It involves the following packages: DataFormats/L1CaloTrigger @smuzaffar, @nclopezo, @mulhearn can you please review it and eventually sign? Thanks. |
|
Bypassing the signature since the change is trivial. @mulhearn please complain if this is wrong. |
ktf
added a commit
that referenced
this pull request
Oct 9, 2013
Misc cleanups -- Make static const value visible inline.
|
It is trivial, but takes a while to compile due to the dependencies. Now I see the Jenkins build is available, so it is fine with me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subsequent clang static analyzer complains. These should really be a constexpr,
but we cannot do it until ROOT6.