bsunanda:Run2-alca20 Backport from 7_6 codes to fix crashes in relval

[bsunanda]

Fixes the crash in the AlCa step for IsoTrig part (also the fix from Salvatore is needed - the AlCaReco should be done in the same step as Reco)

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_7_4_X.

bsunanda:Run2-alca20 Backport from 7_6 codes to fix crashes in relval

It involves the following packages:

Calibration/HcalAlCaRecoProducers

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 7340555
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10294/7786/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10294/7786/summary.html

[diguida]

please test

[diguida]

As reported by @bsunanda the 76X version has all the fixes: no crashes reported, events are selected.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9070/console

[davidlange6]

@diguida - seems AlCa asked for this in the ORP - if so, please sign asap

[diguida]

@davidlange6 well, the request came from HCAL DPG, and we supported it :-)
I just want to re-run the tests on a recent IB to see nothing is wrong...

[cmsbuild]

+1
Tested at: 7340555
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10294/9070/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10294/9070/summary.html

[diguida]

@bsunanda I was reviewing this PR. There is something I do not understand:
the file Calibration/HcalAlCaRecoProducers/src/AlCaGammaJetProducer.cc is not included in the original PR #10178
Is this change included in another PR to be back-ported?

Forget about the test cfg

For the rest, everything is fine.

[bsunanda]

@diguida This was a bug fix to AlCaGammaJetProducer.cc which is identical to what has been in 7_6_X since pre4 or earlier. So this has been tested

---

From: Salvatore Di Guida [notifications@github.com]
Sent: 27 October 2015 14:18
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-alca20 Backport from 7_6 codes to fix crashes in relval (#10294)

@bsunandahttps://github.com/bsunanda I was reviewing this PR. There is something I do not understand:
the file Calibration/HcalAlCaRecoProducers/src/AlCaGammaJetProducer.cchttps://github.com//pull/10294/files#diff-44212e166137a43243b4d13b335b25b0 is not included in the original PR #10178#10178
Forget about the test cfghttps://github.com//pull/10178/files#diff-3531fcee0ee8ad0f7ae29584888b86e9
Is this change included in another PR to be back-ported?

For the rest, everything is fine.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/10294#issuecomment-151491641.

[bsunanda]

@diguida All the contents are tested in 7_6_X. Could you take care of this backport PR?

---

From: Sunanda Banerjee
Sent: 27 October 2015 18:06
To: cms-sw/cmssw; cms-sw/cmssw
Subject: RE: [cmssw] bsunanda:Run2-alca20 Backport from 7_6 codes to fix crashes in relval (#10294)

@diguida This was a bug fix to AlCaGammaJetProducer.cc which is identical to what has been in 7_6_X since pre4 or earlier. So this has been tested

---

From: Salvatore Di Guida [notifications@github.com]
Sent: 27 October 2015 14:18
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-alca20 Backport from 7_6 codes to fix crashes in relval (#10294)

@bsunandahttps://github.com/bsunanda I was reviewing this PR. There is something I do not understand:
the file Calibration/HcalAlCaRecoProducers/src/AlCaGammaJetProducer.cchttps://github.com//pull/10294/files#diff-44212e166137a43243b4d13b335b25b0 is not included in the original PR #10178#10178
Forget about the test cfghttps://github.com//pull/10178/files#diff-3531fcee0ee8ad0f7ae29584888b86e9
Is this change included in another PR to be back-ported?

For the rest, everything is fine.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/10294#issuecomment-151491641.

[davidlange6]

@diguida, @mmusich - any reason not to merge this? Seems to come up every week as a question. Please complain if its not.

[davidlange6]

I guess not.. merging this

[diguida]

@davidlange6 thanks for anticipating me.
I have checked that also the fix to Calibration/HcalAlCaRecoProducers/src/AlCaGammaJetProducer.cc was the same as 76X.
So, everything is fine.

[diguida]

+1
Formal, just to summarise my checks:

• Backport of bsunanda:Run2-alca19 Fix for the crash in the relval for AlCa step with IsoTrack #10178 (mainly for IsoTrack)
• Backport of changes to HcalGammaJet (originally in bsunanda:Run2 alca14 Get rid of unused variables and avoid explicit names #9062, https://github.com/cms-sw/cmssw/pull/9062/files#diff-44212e166137a43243b4d13b335b25b0)