Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try converting RecoParticleFlow/PFTracking to GBRForest + GlobalCache (75X) #10367

Merged
merged 7 commits into from Jul 30, 2015

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Jul 25, 2015

Backport of #10143

@lgray lgray changed the title Try converting RecoParticleFlow/PFTracking to GBRForest + GlobalCache Try converting RecoParticleFlow/PFTracking to GBRForest + GlobalCache (75X) Jul 25, 2015
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Jul 25, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_5_X.

Try converting RecoParticleFlow/PFTracking to GBRForest + GlobalCache (75X)

It involves the following packages:

RecoParticleFlow/PFClusterTools
RecoParticleFlow/PFTracking

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Jul 26, 2015

@cmsbuild please test

@lgray
Copy link
Contributor Author

lgray commented Jul 28, 2015

tests stuck here please resubmit.

@Dr15Jones
Copy link
Contributor

@smuzaffar the tests appear stuck

@davidlange6
Copy link
Contributor

Please test
(Chris you can ask too)

On Jul 28, 2015, at 1:59 PM, Chris Jones <notifications@github.commailto:notifications@github.com> wrote:

@smuzaffarhttps://github.com/smuzaffar the tests appear stuck


Reply to this email directly or view it on GitHubhttps://github.com//pull/10367#issuecomment-125574505.

@cvuosalo
Copy link
Contributor

+1

For #10367 17de6f2

Putting GBRForest objects into edm::GlobalCaches to reduce memory usage for multi-threaded jobs. There should be no significant changes in monitored quantities. Reduction in memory use has been verified in the already merged 76X version of this PR, #10143.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-07-28-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants