Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to select tracks by originalAlgo or algoMask to RecoTrackSelectors #10418

Merged

Conversation

makortel
Copy link
Contributor

This PR adds a possibility to select tracks by originalAlgo or algoMask in RecoTrackSelectors. We are considering to switch the offline tracking validation to select per-iteration tracks by either of them (to be done later, ease of validation of that pre-release will be ensured), and will make use of them (+ current algo) in private studies.

Tested in CMSSW_7_6_X_2015-07-27-1800, no changes expected in results.

@rovere @VinInn

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X.

Add possibility to select originalAlgo to RecoTrackSelectors

It involves the following packages:

CommonTools/RecoAlgos
HLTrigger/Configuration
PhysicsTools/RecoAlgos

@perrotta, @cmsbuild, @cvuosalo, @fwyzard, @monttj, @Martin-Grunewald, @slava77, @vadler can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @abbiendi, @mmarionncern, @jhgoh, @Martin-Grunewald, @jdolen, @nhanvtran, @jalimena, @schoef, @mariadalfonso, @geoff-smith, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Jul 28, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@VinInn
Copy link
Contributor

VinInn commented Jul 28, 2015

"This is a preparatory step to switch the offline tracking validation to select per-iteration tracks by originalAlgo instead of algo"
I was thinking about that and, at least for what concern jetcore and muons I am not fully sure this is what we really want...
anyhow this PR is ok,
we will need to understand the info we will get for the eff/fake selecting on originalAlgo

@slava77
Copy link
Contributor

slava77 commented Jul 31, 2015

+1

for #10418 d2922fb

  • code changes are OK
  • jenkins shows no differences in comparisons with the baseline as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants