Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PreMixing input tags to read CSC information from unpacker #10456

Merged
merged 1 commit into from Jul 29, 2015

Conversation

mdhildreth
Copy link
Contributor

Forgot to change CSC input tags to read information from unpacker rather than directly from digis once the Post_LS1 customizations were changed. Hangover from the late arrival of the CSC packer/unpacker.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mdhildreth for CMSSW_7_5_X.

Change PreMixing input tags to read CSC information from unpacker

It involves the following packages:

SimGeneral/DataMixingModule

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mdhildreth
Copy link
Contributor Author

+1

@mdhildreth
Copy link
Contributor Author

What does it mean that this branch is up-to-date with the base branch? These changes are not in the latest IB, for example? I'm confused...

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

I think it means that your branch can be merged ok. Maybe there is more to it though

davidlange6 added a commit that referenced this pull request Jul 29, 2015
Change PreMixing input tags to read CSC information from unpacker
@davidlange6 davidlange6 merged commit 78b3b2c into cms-sw:CMSSW_7_5_X Jul 29, 2015
@mdhildreth mdhildreth deleted the 750_CSC_PreMixing_Fix branch July 29, 2015 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants