Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RecoJets_EventContent_cff.py #10526

Merged
merged 1 commit into from Aug 7, 2015
Merged

Conversation

jeongeun
Copy link
Contributor

@jeongeun jeongeun commented Aug 3, 2015

Update the standard RECO and AOD EventContent definitions to have no wildcards of module
change specified module

'keep fixedGridRho_',

No module
#'keep caloTowers_*',

Update the standard RECO and AOD EventContent definitions to have no wildcards of module
change specified module
#'keep *_fixedGridRho*_*_*',
No module
   #'keep *_caloTowers_*_*',
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2015

A new Pull Request was created by @jeongeun for CMSSW_7_6_X.

Update RecoJets_EventContent_cff.py

It involves the following packages:

RecoJets/Configuration

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @TaiSakuma, @jdolen, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Aug 3, 2015

@cmsbuild please test
[proposed changes look good at the first glance]

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2015

-1
Tested at: ec93e83
you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10526/6915/summary.html

@slava77
Copy link
Contributor

slava77 commented Aug 3, 2015

it looks like somebody broke the matrix

@slava77
Copy link
Contributor

slava77 commented Aug 3, 2015

@cmsbuild please test
CMSSW_7_6_X_2015-08-03-1600 has a working matrix

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2015

@cvuosalo
Copy link
Contributor

cvuosalo commented Aug 6, 2015

+1

For #10526 ec93e83

Updating the standard RECO and AOD EventContent definitions to remove first trailing wildcard; e.g., change *_fixedGridRho*_*_* to *_fixedGridRhoAll_*_*, *_fixedGridRhoFastjetAll_*_*, etc. There should be no change in run-time behavior.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-08-03-1600 show no significant differences, as expected. Tests of workflows 1330.0_ZMM_13 and 4.53_RunPhoton2012B show no change in output files, no change in products, and no significant change in processing times, indicating no change in run-time behavior.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 7, 2015
Update RecoJets_EventContent_cff.py
@cmsbuild cmsbuild merged commit 68892aa into cms-sw:CMSSW_7_6_X Aug 7, 2015
@jeongeun jeongeun deleted the patch-6 branch May 26, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants