Migrate VID BDTs to GlobalCache + GBRForest (75X)

[lgray]

Forward port of #10556

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_5_X.

Migrate VID BDTs to GlobalCache + GBRForest (75X)

It involves the following packages:

RecoEgamma/EgammaTools
RecoEgamma/ElectronIdentification
RecoEgamma/PhotonIdentification

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1
Tested at: 983b0dd
I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 8 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

      ^
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-08-02-2300/src/RecoEgamma/EgammaTools/interface/AnyMVAEstimatorRun2Base.h:32:15: note: overridden virtual function is here
  virtual int findCategory( const edm::Ptrreco::Candidate& particle) const = 0;
              ^
In file included from /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-08-02-2300/src/RecoEgamma/PhotonIdentification/plugins/PhotonMVAValueMapProducer.cc:1:
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-08-02-2300/src/RecoEgamma/EgammaTools/interface/MVAValueMapProducer.h:83:17: error: unused variable 'currentEstimator' [-Werror,-Wunused-variable]
    const auto& currentEstimator = mvaItr->second;
                ^
In file included from /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-08-02-2300/src/RecoEgamma/PhotonIdentification/plugins/PhotonMVAEstimatorRun2Spring15NonTrig.cc:1:
In file included from /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-08-02-2300/src/RecoEgamma/PhotonIdentification/interface/PhotonMVAEstimatorRun2Spring15NonTrig.h:8:
In file included from /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-08-02-2300/src/RecoEgamma/EgammaTools/interface/AnyMVAEstimatorRun2Base.h:10:


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10557/6948/summary.html

[lgray]

Hmm rebase must have gone south. I'll fix it up in a bit.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10557/6948/summary.html

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

Pull request #10557 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

[cmsbuild]

+1
Tested at: e1596fd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10557/6961/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10557/6961/summary.html

[slava77]

+1

for #10557 e1596fd

• the same code changes are applied as in the 76X version Migrate VID BDTs to GlobalCache + GBRForest (76X) #10618 e87c12e
• jenkins test pass and comparisons with the baseline show no difference

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1