Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving GBRForestWriter to CommonTools/Utils #10575

Conversation

ferencek
Copy link
Contributor

@ferencek ferencek commented Aug 4, 2015

This PR moves GBRForestWriter, a fairly general utility, to a more common and more appropriate location.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_6_X.

Moving GBRForestWriter to CommonTools/Utils

It involves the following packages:

CommonTools/Utils

@cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ferencek
Copy link
Contributor Author

ferencek commented Aug 4, 2015

Hmm, this is a bit strange... Shouldn't bot be able to realize that there were also changes in RecoMET/METPUSubtraction

@slava77
Copy link
Contributor

slava77 commented Aug 4, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2015

@slava77
Copy link
Contributor

slava77 commented Aug 7, 2015

+1

for #10575 6b9238b

  • code move is OK, thanks.
  • jenkins tests pass; GBRForestWriter is not a part of tested workflows. So, there are no changes.

davidlange6 added a commit that referenced this pull request Aug 10, 2015
…W_7_6_X_2015-07-31-1100

Moving GBRForestWriter to CommonTools/Utils
@davidlange6 davidlange6 merged commit 5ef978b into cms-sw:CMSSW_7_6_X Aug 10, 2015
@ferencek ferencek deleted the MoveGBRForestWriter_from-CMSSW_7_6_X_2015-07-31-1100 branch August 13, 2015 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants