75x Fireworks:Update collection entry in configuration files

[alja]

This is forward port of #10594

[cmsbuild]

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_5_X.

75x Fireworks:Update collection entry in configuration files

It involves the following packages:

Fireworks/Core

@cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[davidlange6]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1
Tested at: 2981906
I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 8 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_5_X_2015-08-06-1100/src/Fireworks/TableWidget/interface/FWTextTreeCellRenderer.h:149:19: warning: private field 'm_editContext' is not used [-Wunused-private-field]
   const TGGC\*    m_editContext;
                  ^
1 warning generated.
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-08-06-1100/src/Fireworks/Core/src/FWHLTTriggerTableView.cc 
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-08-06-1100/src/Fireworks/Core/src/FWGUIManager.cc:664:70: error: expression result unused [-Werror,-Wunused-value]
         parse("theta()", grammar.use_parser<1>() >> end_p, space_p).full;
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_5_X_2015-08-06-1100/src/Fireworks/Core/src/FWGUIManager.cc:666:68: error: expression result unused [-Werror,-Wunused-value]
         parse("phi()", grammar.use_parser<1>() >> end_p, space_p).full;
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10595/7017/summary.html

[alja]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

@alja - could you have a look at the clang errors?

[alja]

@davidlange6
I fixed all errors which are in Fireworks code. I checked that with option:
scram b vclean && scram build -k -j 8 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

I still see lots of llvm errors which are internal in BOOST. If look more closely they come from use of grammar in CommonTools. I don't think it makes sense to change BOOST code.

PS: I checked the errors in
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10595/7017/summary.html

[davidlange6]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[alja]

+1

I fixed the error. Now there are [-Wmismatched-tags] and [-Wunused-local-typedef] warnings left, which originate in other code.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlt]

Could you make PR with 8a2f447 for CMSSW_7_6_X? That would resolve CLANG IB issues.

[alja]

OK! Will do that soon.

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

+1
Tested at: 8a2f447
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10595/7268/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Pull request #10595 was updated. can you please check and sign again.

[lgray]

@davidlange6 other PRs waiting on this one too (for the clang error)

[davidlange6]

+1