Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APE tool implemented #10601

Merged
merged 7 commits into from Aug 20, 2015
Merged

Conversation

cschomak
Copy link
Contributor

@cschomak cschomak commented Aug 6, 2015

  • APE tool implemented into the release
  • TrackerTreeGenerator (necessary for the APE tool, but might also used for other purposes) included in Alignment/TrackerAlignment
  • Fixes for ApeSettingAlgorithm in CommonAlignmentAlgorithm and AlignmentProducer in CommonAlignmentProducer

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

A new Pull Request was created by @cschomak for CMSSW_7_6_X.

APE tool implemented

It involves the following packages:

Alignment/APEEstimation
Alignment/CommonAlignmentAlgorithm
Alignment/CommonAlignmentProducer
Alignment/TrackerAlignment

The following packages do not have a category, yet:

Alignment/APEEstimation

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @frmeier, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Aug 6, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

The tests are being triggered in jenkins.

@mmusich
Copy link
Contributor

mmusich commented Aug 6, 2015

@cschomak I see that there are several examples of cff in Alignment/APEEstimation/python/samples/. It's good to have those for documentation purposes (maybe linked in a Twiki), but I don't think they all deserve to be included in release. Can you trim down the list to the bare minimum?

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

Pull request #10601 was updated. @cmsbuild, @mmusich, @diguida, @cerminar can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Aug 6, 2015

@cschomak thank you!

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2015

@davidlange6
Copy link
Contributor

@cschomak - the producers/analyzers in this PR need to have consumes statements for all of the products they consume (and ideally use getbytoken instead of getbylabel)

@cschomak
Copy link
Contributor Author

cschomak commented Aug 7, 2015

@davidlange6 - I am not sure what you mean by by consumes statements. Could you give an example?


if isParticleGun:
process.GlobalTag.globaltag = 'DESIGN42_V12::All'
elif isMc:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cschomak this is not updated, please move to a more recent GT in condDB v2

@mmusich
Copy link
Contributor

mmusich commented Aug 11, 2015

this file Alignment/APEEstimation/test/cfgTemplate/produceOfflineValidationTex.py duplicates Alignment/OfflineValidation/scripts/produceOfflineValidationTex.py? Can you please remove duplications?

@cmsbuild
Copy link
Contributor

Pull request #10601 was updated. @cmsbuild, @mmusich, @diguida, @cerminar can you please check and sign again.

@cschomak
Copy link
Contributor Author

@mmusich I was probably not strict enough when cleaning up thinks I did not need yet. Some are outdated and I think Ajay included some to test the tool, but they are not required.
I removed these files now and changed the config as you suggested

@mmusich
Copy link
Contributor

mmusich commented Aug 12, 2015

please test

@mmusich
Copy link
Contributor

mmusich commented Aug 12, 2015

+1
provided jenkins agrees

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants