Beam Halo filter bug fix

[lathomas]

Now properly reinitiliazing SegmentIsGood in the second segment loop

[cmsbuild]

A new Pull Request was created by @lathomas for CMSSW_7_6_X.

Beam Halo filter bug fix

It involves the following packages:

RecoMET/METAlgorithms

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @jdolen, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 71e9714
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10642/7087/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
96ab5d7
77953df
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10642/7087/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10642/7087/git-merge-result

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10642/7087/summary.html

[cvuosalo]

+1

For #10642 71e9714

Very small bug fix for the beam halo filter used with CSC segments. There should be no changes except those related to recovery of a few CSC segments. The 75X version of this PR, #10634, has already been approved by Reco.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-08-08-2300 show no significant differences, except for the addition of a few CSC segments that the old buggy code missed, as shown below. These plots are from workflow 4.53_RunPhoton2012B.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1