New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New track algorithm names for HI muon RegIt #10653
Conversation
iterative tracking.
highPurity can be set)
A new Pull Request was created by @echapon (Emilien Chapon) for CMSSW_7_6_X. New track algorithm names for HI muon RegIt It involves the following packages: DataFormats/TrackReco @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
It needs also similar MVA selection for tight and highPurity as used in original HI tracking. In that case tracks will have uniform quality based on the reconstruction (primary, detached, pixelpair) rather then origin (initial or muon-regional). |
ha, right. Let me make this change. |
I do not know what "algoSize = 46" will cause to algomask... (schema evolution needed???) |
The tests are being triggered in jenkins. |
@@ -315,7 +316,8 @@ | |||
<class name="edm::Ref<std::vector<reco::TrackExtra>,reco::TrackExtra,edm::refhelper::FindUsingAdvance<std::vector<reco::TrackExtra>,reco::TrackExtra> >"/> | |||
<class name="edm::RefVector<std::vector<reco::TrackExtra>,reco::TrackExtra,edm::refhelper::FindUsingAdvance<std::vector<reco::TrackExtra>,reco::TrackExtra> >"/> | |||
|
|||
<class name="reco::Track" ClassVersion="15"> | |||
<class name="reco::Track" ClassVersion="17"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happened to version 16?
self answer: ROOT5 version (sic)
src = 'hiRegitMuDetachedTripletStepTrackCandidates' | ||
) | ||
|
||
|
||
import RecoTracker.FinalTrackSelectors.multiTrackSelector_cfi | ||
import RecoHI.HiTracking.hiMultiTrackSelector_cfi | ||
hiRegitMuDetachedTripletStepSelector = RecoTracker.FinalTrackSelectors.multiTrackSelector_cfi.multiTrackSelector.clone( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Selectors have to be cloned from RecoHI.HiTracking.hiMultiTrackSelector_cfi.hiMultiTrackSelector object. PR will be updated.
@cmsbuild please test |
The tests are being triggered in jenkins. |
Yes, I would say these small changes look fine. |
Is that dimuonHistograms InvMass plot now identical? On 8/25/15 4:10 PM, Carl Vuosalo wrote:
|
Yes, this histogram now looks good (I checked directly inside https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10653/7616/runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/DQM_V0001_R000182124__Global__CMSSW_X_Y_Z__RECO.root) |
(for consistency with cms-sw#10653)
@echapon: For comparison, here are the LM dimuons that only slightly increase by about 1.6%: |
Thank you for reporting this issue with the high mass di-tracker muons histogram. I had only looked at the default 20 events, which is why I had missed this.
Because of the first and last two characteristics, I think that these problematic dimuon pairs will disappear at the analysis level (even assuming we will look at tracker muons, we require at least 1 pixel hit, and requiring a loose dxy cut like |dxy|<1 would kill these muons too). I would therefore say that we can live with these few high pt but poor quality fake muons. |
+1 Small adjustments for Heavy Ion regional iterative tracking. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-08-24-1100 show a number of small differences, none significant. An extended test of workflow 140.53 with 70 events against baseline CMSSW_7_6_0_pre3 shows similar differences, plus additional dimuons, but, as discussed above, these differences are acceptable.
Another time measure:
Largest apparent source of time increase:
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
New track algorithm names for HI muon RegIt
This PR involves the following small adjustments concerning regional iterative tracking (RegIt) for heavy ion muons:
This PR is not expected to significantly change the reconstruction, except a tiny (sub-percent) increase of charged PF multiplicity in some events with high muon multiplicity.