Add HF Minimum Bias algorithm to Stage1 Emulator (backport 74X #10695)

[harmonicoscillator]

Backport of #10695 to 74X.

[cmsbuild]

A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_7_4_X.

Add HF Minimum Bias algorithm to Stage1 Emulator (backport 74X #10695)

It involves the following packages:

L1Trigger/L1TCalorimeter

@cmsbuild, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[mulhearn]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: c971516
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10697/7360/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10697/7360/summary.html

[mulhearn]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

@richard-cms @mulhearn - this is expected to change results (eg, in the 25ns MC). Is that correct?

[harmonicoscillator]

This PR alone will not change any results on MC, because an upstream issue with the HCAL digis means that the new algo will always return 0 for MC. For Data, the digis are properly packed/unpacked, so depending on the GT menu these HF Minimum Bias bits will actually be used.

[davidlange6]

@richard-cms - I was partly asking because I saw changes in workflow 25202 in the comparisons. maybe that is purely internal to the L1 given the issue you mention?

[harmonicoscillator]

The 7_6_X branch was successfully merged. Is there any problem with this branch?

[mulhearn]

@davidlange6: is this all cleared up or is there some concern from the relvals?

[davidlange6]

+1