Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel cluster splitting and jet core iteration for HI Tracking #10777

Merged
merged 8 commits into from Aug 20, 2015

Conversation

dgulhan
Copy link
Contributor

@dgulhan dgulhan commented Aug 14, 2015

Pixel cluster splitting and jet core iteration as it is in done in pp tracking is implemented in HI tracking. The difference is the jet collection, jets used in heavy ions have iterative Pu background subtraction.

Latest related presentations in HI Tracking meetings:
https://indico.cern.ch/event/438299/

Same as PR 10775 for CMSSW_7_6_X.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dgulhan for CMSSW_7_5_X.

Pixel cluster splitting and jet core iteration for HI Tracking

It involves the following packages:

Configuration/StandardSequences
RecoHI/Configuration
RecoHI/HiJetAlgos
RecoHI/HiTracking
RecoLocalTracker/Configuration

@cmsbuild, @cvuosalo, @franzoni, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @yslai, @forthommel, @yduhm, @gbenelli, @echapon, @threus, @makortel, @jlagram, @cerati, @mandrenguyen, @yetkinyilmaz, @GiacomoSguazzoni, @rovere, @VinInn, @richard-cms, @nickmccoll, @MiheeJo, @jazzitup, @yenjie, @Martin-Grunewald, @kurtejung, @gpetruc, @istaslis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #10777 was updated. @cmsbuild, @cvuosalo, @franzoni, @davidlange6, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #10777 83782f0

Adding pixel cluster splitting and jet core iteration to Heavy Ion tracking. #10775 is the 76X version of this PR, and it has already been approved by Reco.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-08-14-1100 show no significant differences. Additional information about processing time changes can be found in #10775.

@cvuosalo
Copy link
Contributor

hold
Investigation of timing is in progress. See #10775 for more.

@cmsbuild cmsbuild added the hold label Aug 15, 2015
@slava77
Copy link
Contributor

slava77 commented Aug 18, 2015

@cmsbuild pelase test

@cmsbuild
Copy link
Contributor

Pull request #10777 was updated. @cmsbuild, @cvuosalo, @franzoni, @davidlange6, @slava77 can you please check and sign again.

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #10777 bbecc0d

Second approval by Reco. The latest code changes are satisfactory, and new Jenkins tests still show no significant differences.

davidlange6 added a commit that referenced this pull request Aug 20, 2015
Pixel cluster splitting and jet core iteration for HI Tracking
@davidlange6 davidlange6 merged commit bc761bc into cms-sw:CMSSW_7_5_X Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants