Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize GoodVetexFilter #10794

Merged

Conversation

Dr15Jones
Copy link
Contributor

Added necessary consumes call, switched to getByToken and converted
to be a 'global' module.

Added necessary consumes call, switched to getByToken and converted
to be a 'global' module.
@Dr15Jones
Copy link
Contributor Author

@slava77 This should fix the problem with GoodVertexFilter

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X.

Modernize GoodVetexFilter

It involves the following packages:

DPGAnalysis/Skims

@cmsbuild, @srimanob, @boudoul, @franzoni can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@slava77
Copy link
Contributor

slava77 commented Aug 14, 2015

@davidlange6 in case you could merge that before -2300 build starts, it would be nice
.. a more likely case is -1100 though

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

davidlange6 added a commit that referenced this pull request Aug 15, 2015
@davidlange6 davidlange6 merged commit 80729be into cms-sw:CMSSW_7_6_X Aug 15, 2015
@Dr15Jones Dr15Jones deleted the makeGoodVertexFilterThreadSafe branch August 26, 2015 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants