New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DQM/PixelLumi: definite static const int members #10859
DQM/PixelLumi: definite static const int members #10859
Conversation
The patch resolves issue with Clang compiler (3.7.0). N3690 (should be C++11 standard), 9.4.2/3 ... The member shall still be defined in a namespace scope if it is odr-used (3.2) in the program and the namespace scope definition shall not contain an initializer. 9.4.2/4 talks about how `const static` data members are being handled. Also standard says that no diagnostic is required by compiler. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
For the record, this was causing link-time error:
|
A new Pull Request was created by @davidlt for CMSSW_7_6_X. DQM/PixelLumi: definite static const int members It involves the following packages: DQM/PixelLumi The following packages do not have a category, yet: DQM/PixelLumi @cmsbuild can you please review it and eventually sign? Thanks. |
@davidlange6 @smuzaffar This package is still not assigned to any category. |
cms-sw/cms-bot#530 to resolve the new-package-pending |
new package is now recognized by cms-bot. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
DQM/PixelLumi: definite static const int members
The patch resolves issue with Clang compiler (3.7.0).
N3690 (should be C++11 standard), 9.4.2/3
9.4.2/4 talks about how
const static
data members are being handled.Also standard says that no diagnostic is required by compiler.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch