Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM/PixelLumi: definite static const int members #10859

Merged
merged 1 commit into from Aug 21, 2015

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Aug 19, 2015

The patch resolves issue with Clang compiler (3.7.0).

N3690 (should be C++11 standard), 9.4.2/3

...
The member shall still be defined in a namespace scope if it
is odr-used (3.2) in the program and the namespace scope definition
shall not contain an initializer.

9.4.2/4 talks about how const static data members are being handled.

Also standard says that no diagnostic is required by compiler.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

The patch resolves issue with Clang compiler (3.7.0).

N3690 (should be C++11 standard), 9.4.2/3

    ...
    The member shall still be defined in a namespace scope if it
    is odr-used (3.2) in the program and the namespace scope definition
    shall not contain an initializer.

9.4.2/4 talks about how `const static` data members are being handled.

Also standard says that no diagnostic is required by compiler.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@davidlt
Copy link
Contributor Author

davidlt commented Aug 19, 2015

For the record, this was causing link-time error:

tmp/slc6_amd64_gcc493/src/DQM/PixelLumi/plugins/DQMPLumDQMPlugins/PixelLumiDQM.o: In function `PixelLumiDQM::bookHistograms(DQMStore::IBooker&, edm::Run const&, edm::EventSetup const&)':
/data/davidlt/clang3.7/CMSSW_7_6_CLANG_X_2015-08-17-1101/src/DQM/PixelLumi/plugins/PixelLumiDQM.cc:(.text+0x4304): undefined reference to `PixelLumiDQM::lastBunchCrossing'

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_6_X.

DQM/PixelLumi: definite static const int members

It involves the following packages:

DQM/PixelLumi

The following packages do not have a category, yet:

DQM/PixelLumi

@cmsbuild can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlt
Copy link
Contributor Author

davidlt commented Aug 19, 2015

@davidlange6 @smuzaffar This package is still not assigned to any category.

@slava77
Copy link
Contributor

slava77 commented Aug 19, 2015

cms-sw/cms-bot#530 to resolve the new-package-pending

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@smuzaffar
Copy link
Contributor

new package is now recognized by cms-bot.
@deguio , @danduggan can you please review it and eventually sign? Thanks.

@danduggan
Copy link
Contributor

+1
@davidlt thanks for the fix

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Aug 21, 2015
DQM/PixelLumi: definite static const int members
@cmsbuild cmsbuild merged commit a84e468 into cms-sw:CMSSW_7_6_X Aug 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants