Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed a needed T*::Fit change for thread safety #10949

Merged

Conversation

Dr15Jones
Copy link
Contributor

In a previous commit which changed calls to T*::Fit to be the thread
safe form, one call was missed.
This was found by the new static analyzer update.

This has been sitting in my repository for months becuase I forgot to do a pull request.

In a previous commit which changed calls to T*::Fit to be the thread
safe form, one call was missed.
This was found by the new static analyzer update.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X.

Missed a needed T*::Fit change for thread safety

It involves the following packages:

DQM/BeamMonitor

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Aug 27, 2015
Missed a needed T*::Fit change for thread safety
@davidlange6 davidlange6 merged commit 7fa71bc into cms-sw:CMSSW_7_6_X Aug 27, 2015
@Dr15Jones Dr15Jones deleted the missedFitChangeBeamMonitor branch September 24, 2015 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants