Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated paths (DiPhoton, HighPtPhoton). #11046

Closed
wants to merge 1 commit into from

Conversation

ryonamin
Copy link

For 76X.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ryonamin (Ryo Yonamine) for CMSSW_7_6_X.

Updated paths (DiPhoton, HighPtPhoton).

It involves the following packages:

HLTriggerOffline/Exotica

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Sep 2, 2015

please test

@deguio
Copy link
Contributor

deguio commented Sep 2, 2015

+1
provided it passes the tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

1 similar comment
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@davidlange6
Copy link
Contributor

@ryonamin - hum, seems this does not merge...

@ryonamin
Copy link
Author

ryonamin commented Sep 4, 2015

I guess it is because I had to add "," to same line(s) in different PRs to add new paths at the end of the path list.
But this is the case, the conflict can be easily seen by eyes and can be solved easily, I think.
Anyway please let me know what I should do for this issue.
Thank you in advance!

@ryonamin
Copy link
Author

ryonamin commented Sep 7, 2015

Should I make another PR from the latest IB instead of this PR? or should I just wait?
Thank you for your suggestion in advance.

@davidlange6
Copy link
Contributor

@ryonamin - lets start from a new PR - assuming it merges ok, I will merge into 76x right away. Thanks

@ryonamin
Copy link
Author

Thank you for your suggention. I have made another PR (#11219).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants