Streamer output modules ported to one::OutputModule (76X) #11115

smorovic · 2015-09-03T21:05:11Z

Migrates EvFOutputModule (DAQ) and EventStreamFileWriter from legacy to one::OutputModule interface

template, and adding override

…minosityBlocks> is needed to compile (in analogy to PoolOutputModule) *streamer output module now also needs beginLumi and endLumi handlers

cmsbuild · 2015-09-03T21:07:20Z

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_7_6_X.

Streamer output modules ported to one::OutputModule (76X)

It involves the following packages:

EventFilter/Utilities
IOPool/Streamer

@smuzaffar, @Dr15Jones, @cvuosalo, @emeschi, @cmsbuild, @slava77, @mommsen can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

cvuosalo · 2015-09-03T21:44:57Z

@cmsbuild please test

cmsbuild · 2015-09-03T21:46:13Z

The tests are being triggered in jenkins.

Dr15Jones · 2015-09-03T21:49:12Z

EventFilter/Utilities/plugins/RecoEventOutputModuleForFU.h

@@ -44,8 +44,8 @@ namespace evf {
    virtual void doOutputEvent(EventMsgBuilder const& msg) const;
    //virtual void beginRun(edm::RunPrincipal const&, edm::ModuleCallingContext const*);
    virtual void beginJob();


override would be nice here as well.

cmsbuild · 2015-09-03T21:54:16Z

-1
Tested at: 1e5236a
I found an error when building:

>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-03-1100/src/DQMServices/StreamerIO/test/DQMStreamerOutputModule.cc 
>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-03-1100/src/IOPool/Streamer/plugins/Module.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-03-1100/src/IOPool/Streamer/bin/CalcAdler32.cpp 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-03-1100/src/IOPool/Streamer/bin/DiagStreamerFile.cpp 
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-03-1100/src/DQMServices/StreamerIO/test/DQMStreamerOutputModule.cc: In constructor 'edm::DQMStreamerOutputModule::DQMStreamerOutputModule(const edm::ParameterSet&)':
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-03-1100/src/DQMServices/StreamerIO/test/DQMStreamerOutputModule.cc:65:20: error: no matching function for call to 'edm::one::OutputModuleBase::OutputModuleBase()'
       currentRun_(0) {
                    ^
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-03-1100/src/DQMServices/StreamerIO/test/DQMStreamerOutputModule.cc:65:20: note: candidate is:
In file included from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/cms/cmssw-patch/CMSSW_7_6_X_2015-09-03-1100/src/FWCore/Framework/interface/one/outputmoduleAbilityToImplementor.h:27:0,
                 from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/cms/cmssw-patch/CMSSW_7_6_X_2015-09-03-1100/src/FWCore/Framework/interface/one/OutputModule.h:24,

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11115/7880/summary.html

smorovic · 2015-09-03T22:01:33Z

IOPool/Streamer/src/StreamerOutputModuleBase.cc

@@ -55,7 +56,8 @@ namespace {

 namespace edm {
  StreamerOutputModuleBase::StreamerOutputModuleBase(ParameterSet const& ps) :
-    OutputModule(ps),
+    one::OutputModuleBase::OutputModuleBase(ps),


Not sure either, but without it compiler complains at template instantiation because tries to use default constructor:

/home/smorovic/CMSSW/CMSSW_7_6_0_pre4/src/EventFilter/Utilities/plugins/RecoEventOutputModuleForFU.h:88:41: error: no matching function for call to 'edm::one::OutputModuleBase::OutputModuleBase()' outBuf_(new unsigned char[1024*1024])

cmsbuild · 2015-09-03T22:26:13Z

Pull request #11115 was updated. @smuzaffar, @Dr15Jones, @cvuosalo, @emeschi, @cmsbuild, @deguio, @slava77, @mommsen, @danduggan can you please check and sign again.

Dr15Jones · 2015-09-03T22:32:40Z

please test

cmsbuild · 2015-09-03T22:41:14Z

The tests are being triggered in jenkins.

cmsbuild · 2015-09-04T00:25:35Z

+1
Tested at: f235dac
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11115/7882/summary.html

cmsbuild · 2015-09-04T01:17:51Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11115/7882/summary.html

Dr15Jones · 2015-09-04T01:38:41Z

+1

fwyzard · 2015-09-04T16:42:33Z

tracked at #10964

cvuosalo · 2015-09-04T20:09:49Z

+1

For #11115 f235dac

Migrating streamer output modules to one::OutputModule to support multi-threading. There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-09-03-1100 show no significant differences, as expected.

deguio · 2015-09-07T16:52:59Z

+1

Streamer output modules ported to one::OutputModule (76X)

smorovic added 3 commits September 3, 2015 14:17

port of StreamerOutputModuleBase to one::OutputModule base class

f514024

changes suggested by Dr15Jones: more appropriate one::OutputModule

0a25142

template, and adding override

*using template in form one::OutputModule<one::WatchRuns,one::WatchLu…

1e5236a

…minosityBlocks> is needed to compile (in analogy to PoolOutputModule) *streamer output module now also needs beginLumi and endLumi handlers

smorovic mentioned this pull request Sep 3, 2015

Streamer output modules ported to one::OutputModule (75X) #11116

Merged

cmsbuild added this to the Next CMSSW_7_6_X milestone Sep 3, 2015

cmsbuild added reconstruction-pending core-pending daq-pending pending-signatures tests-pending orp-pending comparison-pending labels Sep 3, 2015

Dr15Jones reviewed Sep 3, 2015
View reviewed changes

cmsbuild added tests-rejected and removed tests-pending labels Sep 3, 2015

smorovic reviewed Sep 3, 2015
View reviewed changes

smorovic added 2 commits September 4, 2015 00:17

override beginJob

5d09fd0

fix compilation of DQMStreamerOutputModules, update to one::OutputModule

f235dac

cmsbuild added dqm-pending tests-pending and removed tests-rejected labels Sep 3, 2015

cmsbuild removed the tests-pending label Sep 3, 2015

cmsbuild added the tests-started label Sep 3, 2015

cmsbuild added tests-approved and removed tests-started labels Sep 4, 2015

cmsbuild added comparison-available and removed comparison-pending labels Sep 4, 2015

cmsbuild added core-approved and removed core-pending labels Sep 4, 2015

fwyzard mentioned this pull request Sep 4, 2015

migrate modules used by the HLT menu to multithreading (76x) #10964

Closed

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Sep 4, 2015

cmsbuild added dqm-approved and removed dqm-pending labels Sep 7, 2015

davidlange6 added a commit that referenced this pull request Sep 8, 2015

Merge pull request #11115 from smorovic/one-StreamerOutputModule-76X

a6ee609

Streamer output modules ported to one::OutputModule (76X)

davidlange6 merged commit a6ee609 into cms-sw:CMSSW_7_6_X Sep 8, 2015

smorovic mentioned this pull request Sep 14, 2015

Streamer output modules ported to one::OutputModule (74X) #11245

Merged

smorovic deleted the one-StreamerOutputModule-76X branch November 13, 2015 10:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Streamer output modules ported to one::OutputModule (76X) #11115

Streamer output modules ported to one::OutputModule (76X) #11115

smorovic commented Sep 3, 2015

cmsbuild commented Sep 3, 2015

cvuosalo commented Sep 3, 2015

cmsbuild commented Sep 3, 2015

Dr15Jones Sep 3, 2015

cmsbuild commented Sep 3, 2015

smorovic Sep 3, 2015

cmsbuild commented Sep 3, 2015

Dr15Jones commented Sep 3, 2015

cmsbuild commented Sep 3, 2015

cmsbuild commented Sep 4, 2015

cmsbuild commented Sep 4, 2015

Dr15Jones commented Sep 4, 2015

fwyzard commented Sep 4, 2015

cvuosalo commented Sep 4, 2015

deguio commented Sep 7, 2015

Streamer output modules ported to one::OutputModule (76X) #11115

Streamer output modules ported to one::OutputModule (76X) #11115

Conversation

smorovic commented Sep 3, 2015

cmsbuild commented Sep 3, 2015

cvuosalo commented Sep 3, 2015

cmsbuild commented Sep 3, 2015

Dr15Jones Sep 3, 2015

Choose a reason for hiding this comment

cmsbuild commented Sep 3, 2015

smorovic Sep 3, 2015

Choose a reason for hiding this comment

cmsbuild commented Sep 3, 2015

Dr15Jones commented Sep 3, 2015

cmsbuild commented Sep 3, 2015

cmsbuild commented Sep 4, 2015

cmsbuild commented Sep 4, 2015

Dr15Jones commented Sep 4, 2015

fwyzard commented Sep 4, 2015

cvuosalo commented Sep 4, 2015

deguio commented Sep 7, 2015