Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll-back to old configuration to fix issue in VID #11139

Merged

Conversation

matteosan1
Copy link
Contributor

Update of egammaObjectModifier configuration to avoid VID problems.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

A new Pull Request was created by @matteosan1 (Matteo Sani) for CMSSW_7_6_X.

Roll-back to old configuration to fix issue in VID

It involves the following packages:

RecoEgamma/EgammaTools

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Sep 4, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

@cvuosalo
Copy link
Contributor

cvuosalo commented Sep 8, 2015

+1

For #11139 1d6338e

Rolling back to old e/gamma configuration for Mini-AOD to fix issue in VID. #11126 is the 74X version of this PR, and it has already been approved.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-09-03-2300 show no significant differences.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Sep 9, 2015
Roll-back to old configuration to fix issue in VID
@davidlange6 davidlange6 merged commit 800dc34 into cms-sw:CMSSW_7_6_X Sep 9, 2015
@matteosan1 matteosan1 deleted the electronObjectModifier_76X branch October 5, 2015 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants