Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fastjet shape correction for analysis in 74x #11285

Merged
merged 3 commits into from Oct 10, 2015

Conversation

rappoccio
Copy link
Contributor

Here is a fastjet "rho-based" shape correction for future analysis releases in 74x.
Currently this is completely disabled by default. Some advances in fastjet contrib
are forthcoming to make this much faster than it currently is. Until then,
this should remain disabled except for expert usage in analyses.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rappoccio for CMSSW_7_4_X.

Adding fastjet shape correction for analysis in 74x

It involves the following packages:

RecoJets/JetProducers

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @jdolen, @ahinzmann, @yslai, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Sep 16, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@rappoccio
Copy link
Contributor Author

Please hold off on the tests, many apologies but the line "use_common_bge_for_rho_and_rhom" should be commented with the version of fastjet in the release. This will be in future fastjet versions.

@cmsbuild
Copy link
Contributor

Pull request #11285 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

@rappoccio
Copy link
Contributor Author

Apologies again... this is fixed. I accidentally committed my private version with private fastjet.

@slava77
Copy link
Contributor

slava77 commented Sep 16, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #11285 8a8a9ce

Adding Fast Jet shape correction, but disabled by default. There should be no change in standard workflows. The shape correction is intended for expert use by analysts.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_4_X_2015-09-16-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

cmsbuild added a commit that referenced this pull request Sep 18, 2015
Adding fastjet shape correction for analysis in 76x (port of #11285)
cmsbuild added a commit that referenced this pull request Sep 23, 2015
Adding fastjet shape correction for analysis in 75x (port of #11285)
@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 10, 2015
Adding fastjet shape correction for analysis in 74x
@cmsbuild cmsbuild merged commit 757868e into cms-sw:CMSSW_7_4_X Oct 10, 2015
@rappoccio rappoccio deleted the rappoccio_fastjetshape_74x branch February 3, 2018 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants