TDC changes

[andersonjacob]

These are the fixes to the Hcal TDC simulation that are used for the upgrade. The upgrade code lives in the mainstream CMSSW releases as well as the specific SLHC branches. This is to correct the TDC behaviour. As it applies to the Upgrade simulation is has negligible effect on the standard simulation work-flow.

[cmsbuild]

A new Pull Request was created by @andersonjacob for CMSSW_7_0_X.

TDC changes

It involves the following packages:

CalibCalorimetry/HcalAlgos
SimCalorimetry/HcalSimProducers
RecoLocalCalo/HcalRecProducers
RecoLocalCalo/HcalRecAlgos
CalibFormats/CaloObjects
SimCalorimetry/HcalSimAlgos

@smuzaffar, @civanch, @nclopezo, @demattia, @mdhildreth, @thspeer, @rcastello, @giamman, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

[civanch]

I have tried to compile verus recent IB and fail for CalibCalorimetry/HcalAlgols/src/HcalPulseShape

MAy be this pull request is incomplete for 70X?

[nclopezo]

-1
I found an error when building:

Entering library rule at src/RecoLocalCalo/HcalRecAlgos/test
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-23-0200/src/CalibCalorimetry/HcalAlgos/test/HcalShapeIntegrator.cpp 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-23-0200/src/CalibCalorimetry/HcalAlgos/test/HcalPulseContainmentTest.cpp 
Entering library rule at FastSimulation/CaloRecHitsProducer
>> Compiling LCG dictionary: tmp/slc5_amd64_gcc481/src/SimCalorimetry/HcalSimAlgos/src/SimCalorimetryHcalSimAlgos/a/xr.cc
/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-23-0200/src/CalibCalorimetry/HcalAlgos/src/HcalPulseShapes.cc:437:79: error: no 'double HcalPulseShapes::gexp(double, double, double, double, double)' member function declared in class 'HcalPulseShapes'
 double HcalPulseShapes::gexp(double t, double A, double c, double t0, double s) {
                                                                               ^
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-23-0200/src/FastSimulation/CaloRecHitsProducer/test/DigiCheck.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration/ARCHITECTURE/slc5_amd64_gcc481/CMSSW_7_0_X_2013-10-23-0200/src/FastSimulation/CaloRecHitsProducer/test/NoiseCheck.cc 
Entering library rule at SimCalorimetry/HcalSimProducers


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/971/summary.html

[cmsbuild]

Pull request #1138 was updated. @smuzaffar, @civanch, @nclopezo, @demattia, @mdhildreth, @thspeer, @rcastello, @giamman, @slava77 can you please check and sign again.

[andersonjacob]

I removed the function HcalPulseShapes::gexp(...). This was left over from an intermediate step.

[andersonjacob]

This request has a regression that I didn't notice until this morning. It should be closed. I'll submit a new request when the regressions have been corrected.

[nclopezo]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/991/summary.html